Repository navigation
chore(#164): analyse at the PHP 8.2 minimum - #185
Merged
s2x merged 1 commit intoNov 6, 2026
Merged
Conversation
s2x
deleted the
chore/issue-164-tests-exercise-the-php-8-2-minimum-in-ph
branch
November 6, 2026 21:22
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PHPStan analysed at PHP 8.4 although the package floor is PHP 8.2, so code
using PHP 8.3/8.4 functions could pass despite the declared minimum. The
PHP 8.2 unit job also never loaded the real
libfdb_c.phpstan.neon: target is nowphpVersion: 80200, includesphpstan-baseline.neon, and documents the PHP <= 8.3 FFI-stub bug(
FFI::new()/FFI::cast()typed?FFI\CData; fixed in PHP 8.4, php-srca37a3d3d81). No null handling is added to the wrappers.phpstan-baseline.neon(new): only the 73 FFI-stub nullability falsepositives. The two stale
property.notFoundignores were removed..github/workflows/ci.yml: the FoundationDB client is installed for everyunit-matrix entry, so the real-library path runs on PHP 8.2/8.3/8.4.
tests/Unit/NativeClientLibraryPathTest.php: docblock updated from "thePHP 8.4 CI job" to the full matrix;
CHANGELOG.mdrecords the change.Closes #164
How it was tested
vendor/bin/phpstan analyse --memory-limit=512M --no-progressatphpVersion: 80200: no errors. The raw pre-baseline list was exactly 73errors, all FFI-stub nullability; no real 8.2 incompatibility.
libfdb_c7.3.75:NativeClientLibraryPathTest8/8 passed (real-library load, not skipped);full suite 919 tests, 2480 assertions, 6 skipped.
PATH=/tmp/opencode/bin:$PATH bin/lint.sh,actionlint,git diff --checkpass.
Checklist
CHANGELOG.mdupdated under[Unreleased]chore: ...)