Repository navigation
docs(#167): align ext-gmp wording and refresh stale comments - #190
Merged
s2x merged 1 commit intoNov 6, 2026
Merged
Conversation
s2x
deleted the
docs/issue-167-info-align-ext-gmp-requirement-wording-a
branch
November 6, 2026 22:06
This was referenced Nov 6, 2026
Merged
s2x
added a commit
that referenced
this pull request
Nov 6, 2026
## What changed Release v1.2.1. `CHANGELOG.md` renames `[Unreleased]` to `## [1.2.1] - 2026-11-06` and keeps a fresh empty `[Unreleased]` section. This release contains the v1.2.1 batch: compose reliability (blob store, reboot restart, host-user php), lint bootstrap hardening (checksums, portability), PHPStan at the PHP 8.2 floor, macOS platform libraries, compose deduplication/Compose v2, and the `ext-gmp` documentation alignment. The macOS runtime check for #165 remains open/blocked and is not part of this release's verification. No source file carries a version number: `composer.json` has no `version`, and Packagist reads the git tag, so the CHANGELOG section is the only change. ## How it was tested - `ci-ok` on this PR (documentation-only change). - `master` at the merge commit already has a green `ci-ok` from #190. - After merge: annotated tag `v1.2.1`, release workflow creates the GitHub Release from the `[1.2.1]` section, milestone closed, v1.2.2 created and the blocked #165 moved there. ## Checklist - [x] Tests added or updated, and all checks pass - [x] `CHANGELOG.md` updated - [x] Documentation updated - [x] Everything is written in English - [x] The PR title is a Conventional Commit (`chore: ...`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The docs disagreed about
ext-gmp:AGENTS.mdlisted it as required, whileREADME/composer describe it as optional for arbitrary-precision tuple integers,
and the README development prerequisites omitted it. A stale test comment also
claimed CI never has a real
libfdb_c.AGENTS.md: PHP 8.2+ withext-ffiand optionalext-gmp(required forarbitrary-precision integers in the tuple layer), keeping the
libfdb_cnote.README.md: same wording in Requirements and Development prerequisites.composer.json:suggest.ext-gmpnow says optional, required forarbitrary-precision tuple integers.
tests/Unit/NativeClientPartialInitTest.php: the stub comment now explainsthat the stub keeps the singleton lookup independent of a real library, not
that CI has none.
CHANGELOG.mdrecords the change under[Unreleased]/Changed.Closes #167
How it was tested
grep -RIn "ext-gmp"over AGENTS, README, composer.json,TupleCompareTestand
NativeClientPartialInitTest: wording consistent.PATH=/tmp/opencode/bin:$PATH bin/lint.shpasses;git diff --checkclean.(Unreleased section, English-only, relative links) were reproduced manually.
lacks
ext-gmp, which reproduces the pre-existing 23 GMP test errors (not aregression; tracked separately).
Checklist
CHANGELOG.mdupdated under[Unreleased]docs: ...)