Repository navigation
refactor: cognitive-complexity function limit 40, stage 2 of #1198 - #1200
Merged
Merged
Conversation
…r into private methods (#1198)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #1198 (stage 2: function limit 50 → 40, class stays 150).
Changes
ServerWorker::__construct()48 → 1: each callback closure is returned by a private method; assignment order,$this/static binding, captured variables andonWorkerStartstep order unchanged (verified side by side in review).bin/kb-lint.php:parseFile()41 → 0 (newKbFileParser),parseFrontMatter()30 → 6,validateEntry()31 → 1 — differential run old vs new: 1,224 runs, 0 differences.tests/ServerWorkerTest.php+41 lines, no existing assertion removed: the body-size cap is now actually checked on the connection; new sweeper test for connections without context / lastActivity (mutation-checked).phpstan.neon.dist, gate test ceiling, CONTRIBUTING, CHANGELOG.Changelog
Existing
[Unreleased] → Changedentry for #1198 extended.Proof of Work
docs/proof_of_work/1198-cognitive-complexity/— code-decision-3.md, review-3.md (review-critical)Code Review