Conversation
Help and examples previously showed type:name=value (e.g. count:processed=100), which parseMetrics treats as a literal metric name. Document the actual comma-separated name=value input, including custom metrics like queue_depth alongside built-ins. Co-authored-by: August Flanagan <aflanagan@users.noreply.github.com>
aflanagan
marked this pull request as ready for review
September 11, 2026 20:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cronitor ping --metrichelp and examples documented atype:name=valueshape (count:processed=100). That is not what the CLI implements.parseMetricsincmd/ping.gotreats each pair asname=value(key = everything before=, integer value).sendPingthen encodes Telemetry asmetric=name:value. Following the old examples would send a bad metric name such ascount:processed.Change
Docs/help/examples only — parser behavior is unchanged.
--metricflag help: comma-separatedname=value(e.g.queue_depth=42,count=100)count,error_count) plus custom names (queue_depth)--metric "queue_depth=42,count=100"Searched README and other CLI docs; the incorrect
type:name=valueshape existed only incmd/ping.go.Out of scope
Parser/code changes, Java/other SDKs, merging.