Backport #332 to release-2.3 - #355
Open
adamwg wants to merge 1 commit into
Open
Conversation
Since we separated the CLI out of core Crossplane and copied its nix-based build system, three significant build changes have happened in core: 1. We've started using nix's standard `buildGoModule` instead of `gomod2nix` in order to ensure the produced artifacts have necessary dependency data for security scanning (crossplane/crossplane#7549). 2. The nix build has been updated to give each build job its own writeable home directory, solving the `/homeless-shelter` errors we occaisionally see in CI (crossplane/crossplane#7652). 3. The nixpkgs channel has been updated to the latest 26.05 from the EOL 25.11 (crossplane/crossplane#7715). All of these changes are relevant improvements for the CLI build as well, so port them over. This should make our renovate runs more reliable (they often hit issue 2 today) and improve our security posture. Signed-off-by: Adam Wolfe Gordon <awg@upbound.io> (cherry picked from commit 2b043e1)
adamwg
requested review from
a team,
jcogilvie and
tampakrap
as code owners
September 10, 2026 17:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Manual backport of #332 to release-2.3. Most conflicts were in deleted code, which were simple to resolve. One change that conflicted I chose not to backport: the added
binarydefault build target, which was introduced in the 2.4 timeframe.I have:
./nix.sh flake checkto ensure this PR is ready for review.- [ ] Added or updated unit tests.- [ ] Linked a PR or a docs tracking issue to document this change.- [ ] Addedbackport release-x.ylabels to auto-backport this PR.