Skip to content

appsec: return 403, not 200, when the failure action is deny #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mangyan1 wants to merge 1 commit into from
Closed

appsec: return 403, not 200, when the failure action is deny #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/crowdsec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,9 @@ function csmod.AppSecCheck(ip)
if runtime.conf["APPSEC_FAILURE_ACTION"] == DENY then
ok = false
remediation = runtime.conf["FALLBACK_REMEDIATION"]
-- a failing AppSec call returns this initial status code, so a deny
-- failure action must carry the forbidden code, not the 200 placeholder
status_code = ngx.HTTP_FORBIDDEN
end

local method = "GET"
Expand Down