chore: add the DAP task dispatch surface and review directives - #117
Conversation
Two files, both prerequisites for letting DAP's code reviewer run against this repository. `.github/workflows/dap-task.yml` is the dispatch surface session triggers listen on: DAP consumes the `workflow_dispatch` webhook and resolves the trigger definition registered for `(repository, name)`. The job body is inert on purpose — the webhook is the payload, and the `prompt` input is what lets one definition serve many targets. `.dap/review/engineering.md` is this repository's review standard. The platform prompt owns the method and a dimension label set; a repository owns the mechanisms behind those labels, and without them a reviewer works from generic dimensions and produces generic findings. Every `R*` mechanism here is derived from a `Fixed` entry in CHANGELOG.md — a bug shape that has already escaped to main at least once: config resolved but never applied (#103), native/shell-out and per-backend path parity (#71, #72, #102, #103), destructive recreate on spurious config drift (#71, #72), lifecycle probe ordering (v0.1.4), and build-context determinism (#86). Directives are read from the base ref, never the working tree, so a change cannot rewrite the rules it is reviewed under. They are additive: they can add mechanisms and declare parts of the standard out of bounds, never relax a severity or authorize anything. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe change adds repository-wide engineering review directives and a manually triggered ChangesEngineering review directives
DAP task workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds the DAP dispatch workflow and repository review directives without changing CLI or library behavior; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Prerequisites for letting DAP's code reviewer run against this repository. Two files, no behaviour change to the CLI or the library.
.github/workflows/dap-task.ymlThe dispatch surface DAP session triggers listen on. DAP consumes the
workflow_dispatchwebhook this file emits and resolves the trigger definition registered for(repository, name); the job body is inert on purpose, since the webhook is the payload. Thepromptinput overrides the prompt stored on the definition, which is what lets one definition serve many targets..dap/review/engineering.mdThis repository's review standard. The platform prompt owns the method — what a finding is, what evidence it carries, how severity is derived — and a short dimension label set; a repository owns the mechanisms behind those labels. Without them a reviewer works from generic dimensions and produces generic findings.
Every
R*mechanism is derived from aFixedentry inCHANGELOG.md, so each one is a bug shape that has already escaped tomainat least once:probedEnvempty for the whole chaindevcontainers/cliCOPYdigestexecargument constructionCONTRIBUTING.mdPlus an explicit out of bounds section: lint-adjacent nits, scope objections already settled by
PRD.md§4, and no-op dependency bumps.Directives are read from the base ref, never the working tree, so a change cannot rewrite the rules it is reviewed under. They are additive by contract: they can add mechanisms and declare parts of the standard out of bounds, but can never relax a severity, disable a security dimension, or authorize anything.
Merging this puts nothing in motion on its own — a trigger definition and a review policy still have to be registered on the DAP side, and reviews are dispatched explicitly.
Summary by CodeRabbit
New Features
Documentation