Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The workflow cannot execute the non-executable script, and its second jq invocation receives no JSON input.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Consolidates Rust coverage summary generation into one script and simplifies workflow output handling.
Changes:
- Replaces separate summary and per-file scripts with
coverage_report.sh. - Updates the reusable workflow to write the combined report directly.
File summaries
| File | Description |
|---|---|
scripts/coverage/coverage_summary.sh |
Removes the standalone summary generator. |
scripts/coverage/coverage_per_file.sh |
Removes the standalone per-file generator. |
scripts/coverage/coverage_report.sh |
Adds combined Markdown report generation. |
.github/workflows/rust-coverage.yml |
Uses the consolidated report script. |
Review details
- Files reviewed: 1/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ./.shared/scripts/coverage/coverage_per_file.sh < /tmp/coverage.json >> $GITHUB_STEP_SUMMARY | ||
| echo "" >> $GITHUB_STEP_SUMMARY | ||
| echo "</details>" >> $GITHUB_STEP_SUMMARY No newline at end of file | ||
| run: ./.shared/scripts/coverage/coverage_report.sh < /tmp/coverage.json >> "$GITHUB_STEP_SUMMARY" No newline at end of file |
peinjoh
marked this pull request as draft
September 12, 2026 09:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
This applies the actionlint lint to simplify the repeated writing to $GITHUB_STEP_SUMMARY.