Admin/Staff roles rework - #223
Merged
Merged
Conversation
Test Results627 tests +9 627 ✅ +9 55s ⏱️ +4s Results for commit 771d4d1. ± Comparison against base commit 064674a. This pull request removes 3 and adds 12 tests. Note that renamed tests count towards both. |
4 tasks done
calebyhan
added a commit
that referenced
this pull request
Sep 8, 2026
* feat: show referenced records before deleting an admin account
Admins deleting an account had no visibility into what it authored or
last touched (news, static pages, app config, budget entries, finance
hearing settings, calendar events) before the FK link was silently
nulled out. Adds GET /api/admin/accounts/{id}/references, grouped by
record type with counts and manage-page links, and a confirmation
dialog that shows them before delete instead of a plain confirm().
Also fixes FinanceHearingConfig.updated_by, the one FK to admin.id
still NOT NULL with no ondelete rule (missed by #223's pass over the
rest of these).
* bug fixes
* added tests
---------
Co-authored-by: calebyhan <calebhantech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now with Onyen integration admins/staff stuff needed reworking
Changes: