Repository navigation
Add optional threadId to attempt history entries - #86
Open
alexshamrai wants to merge 1 commit into
Open
alexshamrai wants to merge 1 commit into
alexshamrai wants to merge 1 commit into
Conversation
Attempt history entries can record the thread or worker that executed them, using the same contract as the Test threadId. The Test threadId now explicitly describes the final attempt, and producers that run test cases in more than one process or on more than one host are asked to qualify threadId values. No omission rule and no serial-execution guarantee are added.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional
threadIdto attempt history entries, so each previous attempt can record the thread or worker that executed it (new section 11.12.1). Section 9.25 now says the Test-levelthreadIddescribes the final attempt represented by the test object.Following the review in #74, the two fields share one contract, as Test and history
attemptIddo: an optional string at both levels, plus a SHOULD to qualify the value with the process or host when test cases run in more than one process or on more than one host. The change adds no rule for an attempt withoutthreadId, and no serial-execution guarantee.Adds
threadIdto the retry history of the standalone and inline comprehensive examples, a valid document whose previous and final attempts ran on different workers, and type cases rejecting non-string attempt values. Adds the changelog entries under Unreleased. Closes #74.Version metadata is unchanged; the new fixtures use the current 0.2.0, leaving the 0.3.0 alignment to the release preparation in #75. The 0.3.0 stack also edits the 9.25 wording, the Test
threadIdschema description and the Unreleased changelog, and appends to the same normative test files, so bringing this into the stack will need small conflict resolutions. I'm happy to resolve them, or to rebase onto the stack instead.