Skip to content

Honor environment proxies for GitHub API requests - #333

Merged
Ma11hewThomas merged 1 commit into
mainfrom
fix-github-api-proxy
Oct 11, 2026
Merged

Ma11hewThomas merged 1 commit into
mainfrom
fix-github-api-proxy

Conversation

@Ma11hewThomas

Copy link
Copy Markdown
Contributor

GitHub API calls now honor HTTPS_PROXY, HTTP_PROXY and NO_PROXY, including lowercase equivalents, so self-hosted runners can reach GitHub Enterprise Server through an HTTP forward proxy.

Use an environment-aware Undici dispatcher for Octokit requests. Support authenticated CONNECT proxies, prefer lowercase variables, and evaluate bypass rules per destination, including artifact redirects. Preserve GitHub authentication, enterprise API URLs and retry behavior. Document configuration, rebuild the committed Action bundle and prepare patch version 1.3.2.

Validation:

  • Clean install and full npm run all pass; 137 tests pass on Node 24 and Node 26.
  • Ten real local-network proxy cases cover routing, precedence, bypass, authentication and artifact redirects without forwarding GitHub authorization to storage hosts.
  • The actual bundled Action lists and posts mock issue comments through an authenticated proxy on both runtimes, with TLS verification enabled.
  • Full and production dependency audits: zero vulnerabilities; registry signatures verified.
  • All six bundled schemas match installed CTRF byte-for-byte; current schema matches the authoritative source.

Closes #331.

@github-actions

Copy link
Copy Markdown

action-test: Run #222

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
137 137 0 0 0 0 0 4.6s

🎉 All tests passed!

Github Test Reporter by CTRF 💚

@Ma11hewThomas
Ma11hewThomas merged commit dbb0895 into main Oct 11, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub API requests ignore proxy environment variables on GitHub Enterprise Server

1 participant