Skip to content

feat: ship user plugins in every build - #54

Merged
cu-e merged 1 commit into
masterfrom
feat/user-plugins-by-default-master
Nov 10, 2026
Merged

cu-e merged 1 commit into
masterfrom
feat/user-plugins-by-default-master

Conversation

@cu-e

@cu-e cu-e commented Nov 10, 2026

Copy link
Copy Markdown
Owner

What

Removes the user-plugins cargo feature: the plugin crates become ordinary dependencies, so release builds install and run user plugins. The runtime switch [plugins] user_plugins (off by default) and --safe-mode still decide whether a run loads them. ADR 0161.

Why

The owner asked to ship user plugins in the next release.

How it was verified

  • Locally: workspace clippy with -D warnings and cargo fmt pass; xtask architecture and xtask docs --check pass; the notice inputs and test-release-pipeline.cjs pass. The notices were regenerated with the original licenses of wasmi and wasmparser.
  • Not run locally: the workspace tests. The owner asked to merge before CI finishes, so the CI on this PR and release validation run them.

Notes for the reviewer

Merged at the owner's request without waiting for CI.


Generated by Claude Code

Users could not install a plugin from a release: the user-plugin track was
compiled in only with --features nocterm/user-plugins, which no release
built. The feature is gone, and the plugin crates are ordinary dependencies.
A run still loads user plugins only when [plugins] user_plugins is on, and
--safe-mode loads none.

- 57 cfg gates and the placeholder module for builds without plugins are
  removed.
- The xtask compile-out rule and the release-pipeline check that kept the
  feature out of releases are removed. The test-only and banned feature
  rules remain.
- CI builds the example guest in Build and test and runs the workspace
  tests once against the real WASM guest; the separate user-plugin job and
  its clippy pass are gone.
- The notices now cover wasmi and wasmparser, with their original license
  files pinned in licensing/.

ADR 0161 records the decision.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WAgRyZqRCp4XuUHFDB1w3k
@cu-e
cu-e merged commit 83ec876 into master Nov 10, 2026
@cu-e
cu-e deleted the feat/user-plugins-by-default-master branch November 10, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants