Repository navigation
feat: ship user plugins in every build - #54
Merged
Merged
Conversation
Users could not install a plugin from a release: the user-plugin track was compiled in only with --features nocterm/user-plugins, which no release built. The feature is gone, and the plugin crates are ordinary dependencies. A run still loads user plugins only when [plugins] user_plugins is on, and --safe-mode loads none. - 57 cfg gates and the placeholder module for builds without plugins are removed. - The xtask compile-out rule and the release-pipeline check that kept the feature out of releases are removed. The test-only and banned feature rules remain. - CI builds the example guest in Build and test and runs the workspace tests once against the real WASM guest; the separate user-plugin job and its clippy pass are gone. - The notices now cover wasmi and wasmparser, with their original license files pinned in licensing/. ADR 0161 records the decision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WAgRyZqRCp4XuUHFDB1w3k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
user-pluginscargo feature: the plugin crates become ordinary dependencies, so release builds install and run user plugins. The runtime switch[plugins] user_plugins(off by default) and--safe-modestill decide whether a run loads them. ADR 0161.Why
The owner asked to ship user plugins in the next release.
How it was verified
-D warningsandcargo fmtpass;xtask architectureandxtask docs --checkpass; the notice inputs andtest-release-pipeline.cjspass. The notices were regenerated with the original licenses of wasmi and wasmparser.Notes for the reviewer
Merged at the owner's request without waiting for CI.
Generated by Claude Code