Skip to content

Fix clang23 compilation - #318

Merged
mpkorstanje merged 1 commit into
cucumber:mainfrom
martin4861:fix-clang23-build
Sep 18, 2026
Merged

mpkorstanje merged 1 commit into
cucumber:mainfrom
martin4861:fix-clang23-build

Conversation

@martin4861

Copy link
Copy Markdown
Contributor

Summary

Fix clang23 compilation

Details

Add #includes to make compilation work with clang23

How Has This Been Tested?

cmake -S . -B build-clang23 -G Ninja \
  -DCMAKE_C_COMPILER=clang-23 \
  -DCMAKE_CXX_COMPILER=clang++-23 \
  -DCMAKE_CXX_FLAGS="-stdlib=libc++" \
  -DCUKE_STRICT=on
cmake --build build-clang23 --verbose

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to main, keeping only relevant commits.

@mpkorstanje

mpkorstanje commented Sep 18, 2026

Copy link
Copy Markdown
Member

Windows build is broken. But looks unrelated. Cheers!

@mpkorstanje
mpkorstanje merged commit 2d8ef78 into cucumber:main Sep 18, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants