Skip to content

chore: remove the pullRequestsPage org feature flag - #198

Merged
agoldis merged 1 commit into
mainfrom
chore/remove-pull-requests-page-flag
Sep 21, 2026
Merged

agoldis merged 1 commit into
mainfrom
chore/remove-pull-requests-page-flag

Conversation

@agoldis

@agoldis agoldis commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

The Pull requests page is available to every organization now, so pullRequestsPage is gone from the monorepo (currents-dev/currents#3865).

mcp-server/src/host/** is excluded from the source sync, so this repo's own OrgFeatures has to drop the key here. Without it, the shared mcp-server/src/lib/orgFeatures.ts list — typed { [K in OrgFeatureKey]: K } so the two cannot drift — no longer type-checks once the monorepo change lands, which is what the monorepo's sync check reports today.

  • src/host/scopes.ts: dropped pullRequestsPage from OrgFeatures.
  • src/lib/orgFeatures.ts: dropped the same key, matching the monorepo copy that the next sync will overwrite this file with.
  • README.md: the flag is no longer a name --features / CURRENTS_MCP_FEATURES accepts, and the server exits on a name it does not recognize.

Merge this before currents-dev/currents#3865.

npm run verify passes locally: format, readme sync, types, build, 768 tests.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WBJ1qXTQEZ1aqcAVLQiCKZ


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Documentation

    • Updated the documented organization feature flags to remove pullRequestsPage and reflect the currently supported options.
  • Changes

    • Removed support for the pullRequestsPage organization feature flag from the public feature configuration and recognized feature list.

The Pull requests page is available to every organization now, so the flag is
gone from the monorepo. `src/host/scopes.ts` does not sync, so its copy of
`OrgFeatures` has to drop the key here or the shared `lib/orgFeatures.ts` list
stops type-checking against it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WBJ1qXTQEZ1aqcAVLQiCKZ
@baz-reviewer

baz-reviewer Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review this PR on Baz

Baz Summary

Remove the pullRequestsPage organization feature flag from the host feature schema and shared feature-key registry. Update the CLI and environment-variable documentation to reflect the reduced set of accepted feature names.

Topics

TopicDetails
Feature flag removal Remove pullRequestsPage from OrgFeatures and ORG_FEATURE_KEYS so the server’s feature typing and validation match the monorepo.
Modified files (2)
  • mcp-server/src/host/scopes.ts
  • mcp-server/src/lib/orgFeatures.ts
Latest Contributors(2)
UserCommitDate
agoldis@gmail.comchore: remove the pull...September 21, 2026
david.mountney@twkie.netfeat: withhold feature...September 16, 2026
Feature docs Update documented --features and CURRENTS_MCP_FEATURES values to stop advertising the removed flag.
Modified files (1)
  • README.md
Latest Contributors(2)
UserCommitDate
agoldis@gmail.comchore: remove the pull...September 21, 2026
david.mountney@twkie.netfix: generate the READ...September 18, 2026

Merger  Activate to get a short verdict whether this PR is good to go or not

Skills  Activate Skill Maintainer to keep your skills up to date

Planner  Activate Planner to make agent work better

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 5b412951-8c2d-4e00-ad6e-7a14f66bceee

📥 Commits

Reviewing files that changed from the base of the PR and between 8eaa992 and e934fc4.

📒 Files selected for processing (3)
  • README.md
  • mcp-server/src/host/scopes.ts
  • mcp-server/src/lib/orgFeatures.ts
💤 Files with no reviewable changes (2)
  • mcp-server/src/host/scopes.ts
  • mcp-server/src/lib/orgFeatures.ts

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The change removes pullRequestsPage from the public organization feature interface, the organization feature key list, and the README feature flag documentation.

Changes

Organization feature flag contract

Layer / File(s) Summary
Remove pullRequestsPage from feature flag contracts
mcp-server/src/host/scopes.ts, mcp-server/src/lib/orgFeatures.ts, README.md
The OrgFeatures interface and ORG_FEATURE_KEYS no longer include pullRequestsPage. The README feature flag list matches the updated definitions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: miguelangaranocurrents

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the pullRequestsPage organization feature flag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@agoldis
agoldis merged commit 6ab4bb9 into main Sep 21, 2026
7 checks passed
@agoldis
agoldis deleted the chore/remove-pull-requests-page-flag branch September 21, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant