Repository navigation
Conversation
A plugin named "New" gets the slug `new`, and /plugins/new is the submission form, which Next.js resolves before [slug]; the listing is unreachable. Same for `opengraph-image`. Append `-plugin` to those two derived slugs in generate_plugin_slug before the duplicate check. (cherry picked from commit 00c4a7b)
parseFrontmatter accepted a CRLF opening fence but searched for an LF closing fence, so every Windows-authored rule or skill came through with no name or description and the raw frontmatter as its content. The object branch for `author:` was unreachable because the array branch matched the same `key:` line first, so author.name/url/avatar were never read. Normalise CRLF, accept a closing fence on the last line, and decide list vs mapping from the first indented line. (cherry picked from commit 4ffa8c1)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The two open fixes that are not in #477 or #478, in one branch, cherry-picked in numeric order on top of
maine816606. Each keeps its own commit. If a single PR is easier to review, this replaces #479 and #480; if the separate PRs are preferred, close this one.Included
generate_plugin_slugappends-pluginwhen a name would produceneworopengraph-image, so a plugin named "New" no longer gets a slug that opens the submission form instead of its listing (one migration, no app change)parseFrontmatterfinds the closing fence in CRLF files and reads nestedauthor:blocks, so Windows-authored components import with their real name and description, and author metadata is filledThe repros and checks for each are in the original PR descriptions.
Checked on the combined branch
supabase/migrations/20261029_reserved_plugin_slugs.sqlfor Keep generated plugin slugs off the static routes under /plugins/ #479,apps/cursor/src/lib/github-plugin/parse.tsfor fix(github-plugin): parse CRLF frontmatter and nested author blocks #480).