Repository navigation
feat(web): add verbs for people going out to the homepage headline - #288
Merged
Merged
Conversation
bnb
approved these changes
Oct 29, 2026
Coverage Report for apps/web
File CoverageNo changed files found.SizeCompared with main. KiB are 1,024 bytes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds seven verbs to
apps/web/src/lib/headline.jsonfor people who go out, not just promoters: Catch, Go see, Hear, Dance to, Follow, Support, Hype up. They go after the existing five, so the headline still starts on "Find your DJ." Each one reads as " your ." with every noun.Changes the verbs description in
headline.schema.jsonto cover both promoters and people going out."Dance to" is now the longest verb, so the headline's static width grows by 7px at desktop size (316px vs 309px for "Discover"). Nothing moves while the words swap.
How it was tested
vitest run src/lib/headline.test.ts src/lib/components/HeroHeadline.svelte.test.ts src/routes/page.svelte.test.ts: 9 passedpnpm format:checkhomepage-hero-headline--in-the-herostory at 1280px and 390px, light and dark. No horizontal scroll at 390px, and the stacked phone layout is unchanged.Checklist
docs/and--helpstill say what the code does