Skip to content

feat(web): add verbs for people going out to the homepage headline - #288

Merged
bnb merged 1 commit into
mainfrom
bnb/headline-verbs
Oct 29, 2026
Merged

bnb merged 1 commit into
mainfrom
bnb/headline-verbs

Conversation

@botandbang

Copy link
Copy Markdown
Contributor

What and why

Adds seven verbs to apps/web/src/lib/headline.json for people who go out, not just promoters: Catch, Go see, Hear, Dance to, Follow, Support, Hype up. They go after the existing five, so the headline still starts on "Find your DJ." Each one reads as " your ." with every noun.

Changes the verbs description in headline.schema.json to cover both promoters and people going out.

"Dance to" is now the longest verb, so the headline's static width grows by 7px at desktop size (316px vs 309px for "Discover"). Nothing moves while the words swap.

How it was tested

  • vitest run src/lib/headline.test.ts src/lib/components/HeroHeadline.svelte.test.ts src/routes/page.svelte.test.ts: 9 passed
  • pnpm format:check
  • Measured every verb's rendered width in the homepage-hero-headline--in-the-hero story at 1280px and 390px, light and dark. No horizontal scroll at 390px, and the stacked phone layout is unchanged.

Checklist

  • Tests cover the change
  • For the website: Storybook stories cover any new UI states
  • The READMEs, docs/ and --help still say what the code does

@botandbang
botandbang requested a review from bnb as a code owner October 29, 2026 17:10
@github-actions github-actions Bot added the web The Local Network website (apps/web) label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Coverage Report for apps/web

Status Category Percentage Covered / Total
🟢 Lines 94.63% (🎯 93%)
🟰 ±0 pp
6033 / 6375
🟢 Statements 92.97% (🎯 91%)
🟰 ±0 pp
9285 / 9987
🟢 Functions 93.58% (🎯 92%)
🟰 ±0 pp
2363 / 2525
🟢 Branches 83.04% (🎯 80%)
🟰 ±0 pp
4343 / 5230
File CoverageNo changed files found.
Generated in workflow #539 for commit 171a744 by the Vitest Coverage Report Action

Size

Compared with main. KiB are 1,024 bytes.

This pull request main Change
Client JavaScript 620.5 KiB 620.4 KiB +64 B (+0%)
Client JavaScript, brotli 204.9 KiB 204.8 KiB +28 B (+0%)
Client CSS 87.8 KiB 87.8 KiB 0 B (0%)
Client CSS, brotli 12.6 KiB 12.6 KiB 0 B (0%)

@bnb
bnb merged commit 6483a75 into main Oct 29, 2026
50 checks passed
@bnb
bnb deleted the bnb/headline-verbs branch October 29, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web The Local Network website (apps/web)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants