Repository navigation
ci: raise the Rust coverage gates to what the tests reach now - #479
Merged
Merged
Conversation
The Hegel tests alone are the lowest of the two runs held to these gates, so they set them.
Rust coverageFrom run 440. Both are held to the thresholds in .cargo/config.toml.
|
bnb
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the gates in
.cargo/config.tomlnow that the Rust coverage PRs have landed, for lines, functions and regions.cargo coverageholds both the whole suite and the Hegel tests alone to the same gates, so the Hegel run, the lower of the two, sets them.All are percentages from CI on Linux. That run measured #458 before #460 and #462 reached main, so it isn't this exact tree. This PR's own coverage comment is. #462's run read about 0.1 above #460's on the Hegel row, so main shouldn't be lower.
The gates leave some room for how far the Hegel row moves between runs: over the last few PRs on one base, about 0.02 on lines, 0.08 on functions and 0.01 on regions.
Changed
.cargo/config.toml:--fail-under-lines95.2 to 96.8,--fail-under-functions93.9 to 96.2,--fail-under-regions93.3 to 95.3.Added and removed
Nothing.