Skip to content

ci: raise the Rust coverage gates to what the tests reach now - #479

Merged
botandbang merged 2 commits into
mainfrom
bnb/rust-coverage-ratchet
Nov 6, 2026
Merged

botandbang merged 2 commits into
mainfrom
bnb/rust-coverage-ratchet

Conversation

@botandbang

Copy link
Copy Markdown
Contributor

Raises the gates in .cargo/config.toml now that the Rust coverage PRs have landed, for lines, functions and regions. cargo coverage holds both the whole suite and the Hegel tests alone to the same gates, so the Hegel run, the lower of the two, sets them.

lines functions regions
gate before 95.2 93.9 93.3
gate now 96.8 96.2 95.3
#458's last run, Hegel alone 96.85 96.38 95.42
that run, whole suite 98.03 97.5 96.69

All are percentages from CI on Linux. That run measured #458 before #460 and #462 reached main, so it isn't this exact tree. This PR's own coverage comment is. #462's run read about 0.1 above #460's on the Hegel row, so main shouldn't be lower.

The gates leave some room for how far the Hegel row moves between runs: over the last few PRs on one base, about 0.02 on lines, 0.08 on functions and 0.01 on regions.

Changed

  • .cargo/config.toml: --fail-under-lines 95.2 to 96.8, --fail-under-functions 93.9 to 96.2, --fail-under-regions 93.3 to 95.3.

Added and removed

Nothing.

The Hegel tests alone are the lowest of the two runs held to these gates, so they set them.
@botandbang
botandbang requested a review from bnb as a code owner November 6, 2026 02:01
@github-actions github-actions Bot added the tooling Repo config, lint and build tooling, and GitHub settings label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Rust coverage

From run 440. Both are held to the thresholds in .cargo/config.toml.

Tests Lines Functions Regions
All 98.12% (88976/90682) 97.57% (14502/14863) 96.78% (197273/203842)
Hegel property tests alone 97.07% (88027/90682) 96.56% (14351/14863) 95.63% (194924/203842)

@botandbang
botandbang added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit ff9f94e Nov 6, 2026
32 checks passed
@botandbang
botandbang deleted the bnb/rust-coverage-ratchet branch November 6, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling Repo config, lint and build tooling, and GitHub settings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants