Repository navigation
Fix callable typecast arguments with untyped or union parameters - #578
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
Inspect the optional second callable parameter as a
ReflectionType, and inject the database only for an exact namedDatabaseInterfacetype. Keep the existing explicit-argument calling convention for other types. Remove the two obsolete Psalm suppressions for the old expression.🤔 Why?
Fixes #574. A supported three-element typecast rule with an untyped or union-typed second argument prevents
getRepository(...)->findByPK()from loading the entity. A single-parameter callable with an empty argument list also raises an undefined-index warning. The regression uses real repository loading and synthetic SQLite rows, with a typed control.📝 Checklist
Static analysis is not green on the base: Psalm 6.20.0 reports 12 errors before changes. The combined fixes report 11 pre-existing errors outside the changed paths (HasMany, ToOneTrait, Select); the typecast null-reference error is removed. No suppressions were added. Other PHP versions and MySQL/PostgreSQL/SQLServer suites were not run locally.
📃 Documentation
No API/default changes; callable rules already support explicit arguments.