Give an operator's Chat sandbox their own sign-in at each service with a host - #769
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
czpython
force-pushed
the
chat-github-sign-in-in-sandbox
branch
from
October 1, 2026 09:21
ba053fa to
4443ff0
Compare
czpython
force-pushed
the
chat-github-sign-in-in-sandbox
branch
from
October 1, 2026 09:26
4443ff0 to
7a296bd
Compare
czpython
force-pushed
the
chat-github-sign-in-in-sandbox
branch
from
October 1, 2026 09:33
7a296bd to
d7c5124
Compare
czpython
force-pushed
the
chat-github-sign-in-in-sandbox
branch
from
October 1, 2026 09:39
d7c5124 to
53a06d1
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
An operator's Chat sandbox now holds that operator's own sign-in at each service that declares a
hostand has OAuth endpoints, so the command line acts as that person. With a GitHub sign-in,gitandghin Chat act as the operator. An operator without a sign-in gets nothing for that service, and a Bot's sandbox never holds one.Githubdeclareshost = "github.com"and losessecret_name. Every GitHub sandbox entry is named by the service slug and carries the host: a build's throughRepoWorkspace.get_secrets, a review's throughReviewWorkspace.get_secrets(github_reviewerwhen the reviewer App is connected), and the operator's sign-in in Chat.hostand OAuth endpoints and adds the operator's sign-in under the service slug. It names no service.Service.is_grant_revoked. The default is RFC 6749's 400 withinvalid_grant; GitHub overrides it with its 200 andbad_refresh_token. A revoked grant is left out of the next turn instead of failing the sandbox.Agent(secrets=...)refuses a field of an App key service, which issues tokens and has no field a sandbox could hold.Needs a Drukbox with czpython/drukbox#63, which resolves an entry for
github.comto its GitHub service under any name. Without it, a build'sgitandghhave no token.Closes #759