Guard the channel receive in certHandler

We should perhaps guard the channel receive here:

certstream-server-go/internal/certificatetransparency/ct-watcher.go

Lines 550 to 569 in 6ae7d17

    
           for { 
        
           	entry := <-entryChan 
        
           	processed++ 
        
           	if processed%1000 == 0 { 
        
           		log.Printf("Processed %d entries | Queue length: %d\n", processed, len(entryChan)) 
        
           		// Every thousandth entry, we store one certificate as example 
        
           		web.SetExampleCert(entry) 
        
           	} 
        
           	// Run JSON encoding in the background and send the result to the clients. 
        
           	broadcast.ClientHandler.MessageQueue <- entry 
        
           	// Update metrics 
        
           	url := entry.Data.Source.NormalizedURL 
        
           	operator := entry.Data.Source.Operator 
        
           	index := entry.Data.CertIndex 
        
           	metrics.Metrics.Inc(operator, url, index) 
        
           }

to

 entry,ok := <-entryChan 
 if !ok{
   break
 }

its possible that we are burning CPU untill the app fully shutsdown
there is also a possibility of empty values being pushed to consumers ?

Fixed here: #124

Closed by: #124

Navigation Menu

Repository navigation

Guard the channel receive in certHandler #121

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	for {
	entry := <-entryChan
	processed++

	if processed%1000 == 0 {
	log.Printf("Processed %d entries \| Queue length: %d\n", processed, len(entryChan))
	// Every thousandth entry, we store one certificate as example
	web.SetExampleCert(entry)
	}

	// Run JSON encoding in the background and send the result to the clients.
	broadcast.ClientHandler.MessageQueue <- entry

	// Update metrics
	url := entry.Data.Source.NormalizedURL
	operator := entry.Data.Source.Operator
	index := entry.Data.CertIndex

	metrics.Metrics.Inc(operator, url, index)
	}

Guard the channel receive in certHandler #121

Description

Activity

messede-degod commented on Sep 21, 2026

messede-degod commented on Sep 27, 2026

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions