Skip to content

fix: nsq typo #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-Rickyy-b merged 3 commits into from
Sep 26, 2026
Merged

fix: nsq typo #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
677305c
Merge pull request #115 from d-Rickyy-b/dev
d-Rickyy-b Sep 12, 2026
6ae7d17
Merge pull request #119 from d-Rickyy-b/dev
d-Rickyy-b Sep 13, 2026
d8cb1e5
fix: nsq
messede-degod Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config.sample.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ stream_processing:
# Each configuration specifies a stream processing tool to use and its settings.
- name: "kafka-prod"
# Type describes the type of stream processing tool to use.
# Supported types: "kafka", "nqs"
# Supported types: "kafka", "nsq"
type: "kafka"
# The stream type can be any of "full", "lite", "domains-only" - same as the certstream websocket urls
# Default is "full"
Expand All @@ -58,8 +58,8 @@ stream_processing:
# E.g. for Kafka, supported types are "none" / "", "gzip", "snappy", "lz4", "zstd"
compression: ""

- name: "nqs-prod"
type: "nqs"
- name: "nsq-prod"
type: "nsq"
stream: "lite"
enabled: false
server_addr: "127.0.0.1"
Expand Down
8 changes: 4 additions & 4 deletions internal/config/streamprocessing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ import (
)

// StreamProcessorType represents the type of stream processing tool to use.
// Supported types are "kafka" and "nqs".
// Supported types are "kafka" and "nsq".
type StreamProcessorType string

const (
StreamProcessorTypeKafka StreamProcessorType = "kafka"
StreamProcessorTypeNQS StreamProcessorType = "nqs"
StreamProcessorTypeNSQ StreamProcessorType = "nsq"
Comment thread
d-Rickyy-b marked this conversation as resolved.
Resolved
)

// StreamType represents the type of stream to process.
Expand Down Expand Up @@ -63,7 +63,7 @@ func (c Compression) SupportedBy(t StreamProcessorType) bool {
switch t {
case StreamProcessorTypeKafka:
return c == CompressionNone || c == CompressionGzip || c == CompressionSnappy || c == CompressionZstd || c == CompressionLz4
case StreamProcessorTypeNQS:
case StreamProcessorTypeNSQ:
return c == CompressionNone || c == CompressionDeflate || c == CompressionSnappy
default:
return false
Expand Down Expand Up @@ -106,7 +106,7 @@ func (s *StreamProcessor) Valid() bool {
}

switch s.Type {
case StreamProcessorTypeKafka, StreamProcessorTypeNQS:
case StreamProcessorTypeKafka, StreamProcessorTypeNSQ:
default:
log.Fatalf("Invalid stream processor type '%s' for name '%s'\n", s.Type, s.Name)
return false
Expand Down
Loading