Skip to content

fix: relax stream processor server address validation #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-Rickyy-b merged 3 commits into from
Sep 26, 2026
Merged

fix: relax stream processor server address validation #125

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
677305c
Merge pull request #115 from d-Rickyy-b/dev
d-Rickyy-b Sep 12, 2026
6ae7d17
Merge pull request #119 from d-Rickyy-b/dev
d-Rickyy-b Sep 13, 2026
2ebc355
fix: relax stream processor server address validation
messede-degod Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions internal/config/streamprocessing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package config

import (
"log"
"net"
)

// StreamProcessorType represents the type of stream processing tool to use.
Expand Down Expand Up @@ -93,10 +92,11 @@ func (s *StreamProcessor) setDefaults() {

func (s *StreamProcessor) Valid() bool {
s.setDefaults()

ip := net.ParseIP(s.ServerAddr)
if ip == nil {
log.Fatalln("Invalid IP for stream processor:", s.ServerAddr)

// kafka client would throw a error if a address is unreachable
// we only check if the address is specified
if s.ServerAddr == "" {
log.Fatalln("Invalid server address for stream processor:", s.ServerAddr)
return false
}

Expand Down
Loading