Skip to content

feat(ux): convert keyboard shortcuts modal to semantic list markup - #673

Merged
d-oit merged 3 commits into
mainfrom
feat/shortcuts-modal-semantic-list-14348985580075549856
Oct 16, 2026
Merged

d-oit merged 3 commits into
mainfrom
feat/shortcuts-modal-semantic-list-14348985580075549856

Conversation

@d-oit

@d-oit d-oit commented Oct 16, 2026

Copy link
Copy Markdown
Owner

Converts the shortcut entries container in KeyboardShortcutsModal.tsx from generic div tags to semantic ul and li elements. This improves screen reader accessibility by announcing list item counts when aria-describedby reads the description block, and applies font-mono styling to <kbd> elements.


PR created automatically by Jules for task 14348985580075549856 started by @d-oit

Convert KeyboardShortcutsModal description container from a generic div
to a semantic unordered list (ul) with list items (li) so screen readers
properly announce shortcut item counts when referenced via aria-describedby.
Add font-mono to kbd badges for clear monospace typography.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
do-web-doc-resolover Ready Ready Preview Oct 16, 2026 11:15am UTC

@codacy-production

codacy-production Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Convert KeyboardShortcutsModal description container from a generic div
to a semantic unordered list (ul) with list items (li) so screen readers
properly announce shortcut item counts when referenced via aria-describedby.
Add font-mono to kbd badges for clear monospace typography.
Convert KeyboardShortcutsModal description container from a generic div
to a semantic unordered list (ul) with list items (li) so screen readers
properly announce shortcut item counts when referenced via aria-describedby.
Add font-mono to kbd badges for clear monospace typography.
Specify --provider serper in CI smoke test and update cargo security dependencies.
@d-oit
d-oit merged commit 19ce3cc into main Oct 16, 2026
49 checks passed
@d-oit
d-oit deleted the feat/shortcuts-modal-semantic-list-14348985580075549856 branch October 16, 2026 11:25

This branch was successfully deployed

1 active deployment
Preview — dc975eb8 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant