Repository navigation
fix: clippy needless_bool under Rust 1.100 - #9
Merged
Merged
Conversation
Rust 1.100's clippy flags an `if` that returns a bool literal followed by the other literal. Two sites: the DHCP lease cache's is_empty and the nftables rule comparison. Return the condition directly; the cache one asks the map so it no longer goes through len. No behavior change. Found by CI the day 1.100 became stable. Signed-off-by: Michael Johnson <buhnux@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.100's clippy flags an
ifthat returns a bool literal followedby the other literal. Two sites: the DHCP lease cache's is_empty and the
nftables rule comparison. Return the condition directly; the cache one
asks the map so it no longer goes through len.
No behavior change. Found by CI the day 1.100 became stable.