Repository navigation
fix(ASV-4003): Fix default filter regex patterns - #61
Merged
Merged
Conversation
- Remove `$` from `[^&$]` character classes so literal `$` in values is matched - Replace greedy `.*` in EMAIL pattern with `[^&\n\r]*` to stop at `&` boundaries - Convert EMAIL trailing `(&|$)` to lookahead `(?=&|$)` to preserve `&` delimiter - Add `\n\r` to all negated character classes to prevent cross-line matching - Add comprehensive tests for all default FilterPatterns Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
harry-stebbins-dailypay
approved these changes
May 1, 2026
harry-stebbins-dailypay
left a comment
harry-stebbins-dailypay
left a comment
Contributor
There was a problem hiding this comment.
very nice 👍 thorough tests
PocKev
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
Summary
$from[^&$]character classes in PASSWORD, USERNAME, CLIENT_ID, and CLIENT_SECRET patterns so literal$characters in values are properly matched and redacted.*in EMAIL pattern with[^&\n\r]*to prevent matching past&delimiters, and converts trailing(&|$)to a lookahead(?=&|$)so the&separator is preserved in output\n\rto all negated character classes to prevent patterns from matching across newline boundariesFilterPatterns(PASSWORD, USERNAME, CLIENT_ID, CLIENT_SECRET, EMAIL) including key-name variants, edge cases, and a combined integration testTest plan
$in password values is now captured and redacted&delimiter in output🤖 Generated with Claude Code