Repository navigation
fix(ui): review fixes — attack map, first-run screen, i18n, campaign form - #15
Merged
Merged
Conversation
…form
- Attack Surface Map: scale the graph to its column so the crown-jewel
assets are no longer hidden off-canvas; more row spacing for asset labels.
- Remove the client-side "BEGIN SETUP" screen. It installed nothing, showed
on every new browser, and told any visitor to log in as the seeded admin.
Language switch and ethics notice move to the login page.
- Scenarios: count badge matches the active tab, hide a missing duration,
add estimated_time to the six Indonesian scenarios; reset paging in an
effect instead of during render.
- i18n: Live Campaigns, Inbox Triage, Command Center, trainee dashboard and
scenario player now go through i18n, including status/state labels.
- Inbox Triage: add an Indonesian set ("Inbox Senin Pagi") picked by UI
language; seed built-in sets by id so new ones reach existing databases.
- Trainee dashboard: primary actions point to Inbox Triage instead of the
demoted AI challenge; in-progress runs show "in progress", not a score.
- Live campaign form: write the email as plain text (HTML optional) with a
sandboxed preview, default the send window, validate {{.URL}} and dates.
- Backend: a simulation always gets started_at (was missing for scenario
runs and rendered as "Invalid Date").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes from a full click-through review of the admin and trainee UI.
socengwith the.envpassword. Language switch + ethics notice moved to the login page.estimated_timeadded to the six Indonesian scenarios; page reset moved out ofuseMemointo an effect.pending_approval→ "Menunggu persetujuan").{{.URL}}or an invalid window.create_simulationalways setsstarted_at.Test plan
pytest— 205 passed (new: triage seed ×2, simulation start time)ruff check/ruff format --checkCI=true craco build— compiled without warnings🤖 Generated with Claude Code