Skip to content

fix(ui): review fixes — attack map, first-run screen, i18n, campaign form - #15

Merged
dalpan merged 1 commit into
mainfrom
fix/ui-review
Oct 30, 2026
Merged

dalpan merged 1 commit into
mainfrom
fix/ui-review

Conversation

@dalpan

@dalpan dalpan commented Oct 30, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes from a full click-through review of the admin and trainee UI.

  • Attack Surface Map — the SVG had a fixed pixel width wider than its column, so the crown-jewel assets sat off-canvas behind an invisible horizontal scroll. It now scales to the column; row spacing increased so asset labels don't overlap.
  • First-run screen removed — "BEGIN SETUP" appeared on every new browser, installed nothing, and its last step told any visitor to log in as soceng with the .env password. Language switch + ethics notice moved to the login page.
  • Scenarios — header count matches the active tab; missing duration no longer renders as a bare "min"; estimated_time added to the six Indonesian scenarios; page reset moved out of useMemo into an effect.
  • i18n — Live Campaigns, Inbox Triage, Command Center, trainee dashboard and scenario player now use i18n, including status/state labels (pending_approval → "Menunggu persetujuan").
  • Inbox Triage — new Indonesian set "Inbox Senin Pagi" (fictional org/brands), chosen by UI language. Built-in sets are now seeded by id, so a new set reaches databases that already have one, and admin edits are left alone.
  • Trainee dashboard — primary actions go to Inbox Triage instead of the demoted AI challenge; in-progress runs show "in progress" instead of a score and "Invalid Date".
  • Live campaign form — plain-text body with a link-text field and sandboxed preview (HTML mode still available, used for templates); default send window; clear errors for a missing {{.URL}} or an invalid window.
  • Backend — create_simulation always sets started_at.

Test plan

  • pytest — 205 passed (new: triage seed ×2, simulation start time)
  • ruff check / ruff format --check
  • CI=true craco build — compiled without warnings
  • Rebuilt the docker stack and re-checked each change with Playwright screenshots (admin + trainee, ID locale)

🤖 Generated with Claude Code

…form

- Attack Surface Map: scale the graph to its column so the crown-jewel
  assets are no longer hidden off-canvas; more row spacing for asset labels.
- Remove the client-side "BEGIN SETUP" screen. It installed nothing, showed
  on every new browser, and told any visitor to log in as the seeded admin.
  Language switch and ethics notice move to the login page.
- Scenarios: count badge matches the active tab, hide a missing duration,
  add estimated_time to the six Indonesian scenarios; reset paging in an
  effect instead of during render.
- i18n: Live Campaigns, Inbox Triage, Command Center, trainee dashboard and
  scenario player now go through i18n, including status/state labels.
- Inbox Triage: add an Indonesian set ("Inbox Senin Pagi") picked by UI
  language; seed built-in sets by id so new ones reach existing databases.
- Trainee dashboard: primary actions point to Inbox Triage instead of the
  demoted AI challenge; in-progress runs show "in progress", not a score.
- Live campaign form: write the email as plain text (HTML optional) with a
  sandboxed preview, default the send window, validate {{.URL}} and dates.
- Backend: a simulation always gets started_at (was missing for scenario
  runs and rendered as "Invalid Date").

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dalpan
dalpan merged commit 027add1 into main Oct 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant