Repository navigation
docs(openspec): plan #3391 Refuse criteria entries not in the issue body - #4069
Merged
Merged
Conversation
devops-cli-service
Bot
added
type/docs
dan-petty
force-pushed
the
fix/3391-refuse-criteria-entries-not-in-the
branch
from
November 7, 2026 21:38
57efbfb to
c26d7da
Compare
2 tasks done
dan-petty
marked this pull request as ready for review
November 7, 2026 21:45
Owner
Check resultsHead commit:
Skipped check: Audit Defect PR Hardening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plans #3391
The stage check compares a plan's
criterialist with the acceptance criteria that a person wrote in the issue body.criterion_problemsrefuses an entry whose text is not one of them, so a plan can no longer copy a criterion out of the refine block. The plan for #3320 in #3333 mapped five refine-block criteria and every gate accepted it.acceptance_criteriastays the only source: it cuts the refine block off, so an issue with no person-written list gets an emptycriterialist. The replay's paths gate gives the check the issue body of a plan that has acriterialist. Two tests cover a body with no heading and a body whose only list sits in the refine block. The stage prompt states the refusal.Change:
openspec/changes/3391-refuse-criteria-entries-not-in-the/