Skip to content

fix(roadmap): retitle records a skip mark for an item it leaves - #4077

Merged
dan-petty merged 5 commits into
mainfrom
fix/4038-retitle-skip-mark
Nov 7, 2026
Merged

dan-petty merged 5 commits into
mainfrom
fix/4038-retitle-skip-mark

Conversation

@dan-petty

@dan-petty dan-petty commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Retitle took the same long-title items each run and made model calls for items it could not rename. It now records a skip mark (retitle.skipped, a hash of title, body and stage PR) for each item it leaves. It leaves the item out of the next selection until the title, body or stage PR change. This stops repeated model calls and lets later items reach the limit.

Three alternatives tests now read only the log records of their own logger. A span processor that an earlier test shut down added records of another logger, and the tests failed in one CI shard. This is part of the cause in #4062.

Closes #4038

Change: openspec/changes/archive/2026-11-07-4038-retitle-records-a-skip-mark/

Plans #4038. Adds the change folder 4038-retitle-records-a-skip-mark, the key RetitleRecordKey.SKIPPED that the tests import, and tests that fail until the job records and honors the mark.
@dan-petty dan-petty added type/bug Defect, regression, or incorrect runtime behavior scope/roadmap The roadmap jobs: intake, refine, stage, implement and the Service that runs them labels Nov 7, 2026
@dan-petty

Copy link
Copy Markdown
Owner Author

Test record for #4038.

Fail-to-pass: uv run devops ci fail-to-pass --base origin/main (stage 2, at the test commit): 15 tests failed on the base, 2 passed (controls), 0 errored. File: tests/roadmap/test_roadmap_retitle_skip.py (17 tests).

Full uv run devops ci (before archive and rebase): exit 0, all rows pass. The Tests row took 21m59s, over the 5 minute budget. The slowest tests are tests/roadmap/stage/test_roadmap_stage_eval_*, the known class of #3593. This change did not cause it.

After the rebase onto origin/main 8476163: retitle_skip (17), retitle, dry_runs and stage_content tests (139 in total) pass. uv run devops docs generate --check passes.

Risk for review: the hash covers the whole item body, so a refine or alternatives block rewrite returns the item once to the selection. A model failure is recorded as a skip on purpose.

Three tests compared all log records. A span processor shut down by an earlier test in the same worker added records of another logger, so the tests failed in one CI shard. Part of the cause in #4062.
@dan-petty
dan-petty marked this pull request as ready for review November 7, 2026 22:06
@dan-petty
dan-petty merged commit ede93e1 into main Nov 7, 2026
27 of 28 checks passed
@dan-petty
dan-petty deleted the fix/4038-retitle-skip-mark branch November 7, 2026 22:06
dan-petty pushed a commit that referenced this pull request Nov 7, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.84.1](v0.84.0...v0.84.1)
(2026-11-07)


### Bug Fixes

* **roadmap:** retitle records a skip mark for an item it leaves
([#4077](#4077))
([ede93e1](ede93e1))
* **roadmap:** write each stage and alternatives item when done
([#4080](#4080))
([a224adb](a224adb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: dan-petty-release[bot] <346998822+dan-petty-release[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/roadmap The roadmap jobs: intake, refine, stage, implement and the Service that runs them type/bug Defect, regression, or incorrect runtime behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(roadmap): retitle records a skip mark for an item it leaves

1 participant