Repository navigation
Mcc detectors - #1999
Mcc detectors#1999
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python | Oct 17, 2026 5:10p.m. | Review ↗ | |
| Code coverage | Oct 17, 2026 5:10p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 100% [✓ above threshold] |
100% |
| Python | 100% [✓ above threshold] |
100% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
added output examples from the function into documentation
maliagehan
left a comment
There was a problem hiding this comment.
Tests pass, no coverage change, tested in a jupyter notebook (successful), which was added to google drive, added some documentation images since I generated them with testing. I think Noah wanted to have a larger discussion about addtional dependency and how we incorporate CV2 detectors, so won't merge for now.
maliagehan
left a comment
There was a problem hiding this comment.
Like the changes to documentation, we discussed a longer/larger change to color correction that might incorporate mcc more seamlessly into color correction workflow, but for now this function works and it's clear when it should be used. Tests pass, documentation looks good, analysis works (notebook is in google drive).
Describe your changes
Adds a function to use
cv2.mccdetectors in color card detection for times where there are multiple color-cards/similar objects or our other tools are unfamiliar to morecv2inclined users.Type of update
This is a new feature.
Associated issues
None
Additional context
This does not support some of the quality of life stuff that
pcv.transform.detect_color_carddoes, namely the size scaling, but I don't see a way around that with howcv2.mccreturns information on the chips.This also apparently requires
opencv-contribinstead of justopencvsince only that version hascv2.mcc.For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md