Skip to content

remove masked_img return from custom_range threshold method - #2053

Merged
maliagehan merged 2 commits into
v5.0from
remove-masked_img-1767
Oct 17, 2026
Merged

maliagehan merged 2 commits into
v5.0from
remove-masked_img-1767

Conversation

@joshqsumner

@joshqsumner joshqsumner commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes
Removes the masked_img return from threshold.custom_range.

Type of update
This is code cleanup.

Associated issues
closes #1767

Additional context
Image can still be made with pcv.apply_mask if desired.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added this to the PlantCV v5.0 milestone Oct 9, 2026
@joshqsumner joshqsumner added the cleanup Code quality updates label Oct 9, 2026
@deepsource-io

deepsource-io Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 0340268...0577d4a on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Oct 17, 2026 8:27p.m. Review ↗
Code coverage Oct 17, 2026 8:27p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
100%
Python
100%
[✓ above threshold]
100%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@maliagehan maliagehan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests passed, tested in jupyter notebook, no coverage change, tested docs.

@maliagehan
maliagehan merged commit 845253d into v5.0 Oct 17, 2026
5 checks passed
@maliagehan
maliagehan deleted the remove-masked_img-1767 branch October 17, 2026 20:48
@maliagehan maliagehan self-assigned this Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code quality updates ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants