Northmoor: optically center the mark's N - #88
Merged
Merged
Conversation
…model The engine places a baseline at half-leading + font-size — font-size standing in for the true ascent — so the design's line-height: 33pt (box height, browser-centered) sat the N ~2.3pt low in the square. 27.7pt, pixel-measured at 300dpi, centers the ink to within 0.24pt (above 48px / below 49px). Comment marks it for revisit when the engine gains font-metric baselines. Page counts unchanged 30/30, chains hold, docs regenerated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019eLgo72VYmQp3kNz9PZDHs
✅ Changes approved31 documents changed structurally · 0 errors, 329 warnings, 1 info · baseline 31 documents changed, none blocking
9 documents unchanged:
Forme Review · 40 runs · powered by pdf-testkit 0.4.1 |
📄 pdf-testkit —
|
The certificate inlines its own mark geometry (34.5pt box, 14.25pt N) so the shared-css fix didn't reach it — the reviewer caught it still sitting low. Same correction scaled to its font size (line-height 29.5pt), same 300dpi pixel measurement: ink centered to +0.24pt. The only template overriding the mark's line-height. (Re-landed here: the first attempt committed onto a stale branch that another session had checked out — its docs regen lacked the shared-css fix and is discarded.) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019eLgo72VYmQp3kNz9PZDHs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviewer's eye was right: the engine's baseline model (half-leading + font-size, with font-size standing in for true ascent) sat the N ~2.3pt low in the 33pt square — browsers center on real ascent/descent. line-height 27.7pt, pixel-measured at 300dpi, centers the ink to within 0.24pt (sub-pixel at print resolution). Commented for revisit when the engine gains font-metric baselines — the same underlying limitation as the table-cell baseline note. Page counts unchanged 30/30, chains hold, docs regenerated. Expect one more Review batch (every masthead moves ~2pt of ink).