fix(ime): floating window drag moves opposite horizontally on Samsung (#46) - #47
Merged
Merged
Conversation
…#46) Two bugs in one, both from Heide's Galaxy Fold 5 report: - Gravity.TOP or Gravity.START: on Samsung, START resolves to RIGHT for overlay windows — x is measured from the RIGHT edge, so params.x += dx moves the window LEFT (Heide: 'it moves the opposite way horizontally'). Fixed: Gravity.LEFT (explicit, never locale-dependent). - params.y = initY - dy: the minus was compensating for the same Samsung y-axis flip — it happened to work on Samsung but would be inverted on stock Android. Fixed: + dy (correct with TOP gravity everywhere). Both axes now use the standard direction; the drag follows the finger on all devices. Signed-off-by: will wade <willwade@gmail.com>
willwade
force-pushed
the
fix/floating-drag-direction
branch
from
September 15, 2026 21:38
52f1855 to
4d7897e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46 — Heide's Galaxy Fold 5 report: 'When you move the float window horizontally, it moves the opposite way. It moves the correct way vertically, though.' Two bugs: resolving to on Samsung overlays (x-axis inverted), and a compensating on the y-axis that only worked by accident. Both fixed to explicit + standard direction. Two-line fix. DCO signed.