feat(ime): editing toolbar + adaptive dock height + floating resize (#48 #49 #50) - #51
Merged
Merged
Conversation
…e-convert Score 4/10 with 2 criticals + 4 importants; all fixed: Criticals: - C1 Float crashed on first tap: toolbar added to floating while still attached to dockedRoot → IllegalStateException. Fixed: detach before attach (same pattern as canvasHost). - C2 re-anchor double-converted the caret: seedBuffer already does the UTF-16→UTF-8 conversion internally; pre-converting shifted the anchor past the caret for non-ASCII text. Fixed: pass before.length directly. Importants: - I1 toolbar vanished after Float→Dock: exitFloatingMode removed it from floating but never re-added to docked. Fixed: re-insert at index 0. Also fixed the enterFloatingMode fallback path. - I2 empty before-text left engine anchored to stale text. Fixed: newSession() (full reset) when the field is empty. - I3 dock height didn't track fold/unfold. Fixed: onConfigurationChanged recomputes imeHeightPx() and calls setDockedHeight. - I4 36dp touch targets → 48dp (accessibility: Heide is motor-impaired). Minors: wrong ratio comment (0.6→0.47), floatingParams field removed (write-only), grapheme-cluster backspace noted as v1 scope. Signed-off-by: will wade <willwade@gmail.com>
…fold fix - All 7 toolbar buttons now 48dp minimum touch target (5 were 44dp — the height fix only covered half the surface) - onBufferChanged only fires for buffer-MUTATING actions (backspace, cursor, paste) — Copy and Select All no longer discard engine context mid-sentence - Fold-while-floating: the recreated docked root is re-shrunk to 40dp (was full-height behind the floating overlay) - Unused imeHeight local removed Review score trajectory: 4 → 7 → expected 8+. Signed-off-by: will wade <willwade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48 #49 #50 — Heide's three UX suggestions. Editing toolbar (backspace, cursor, clipboard) with engine re-anchoring; adaptive dock height (35% on tablets); floating window resize handle. DCO signed.