[PastaPastaPasta]

Motivation

Follows up on #86 (comment). serialize::str_u64 sealed Value with a module-local Sealed trait, where the crate-wide sealing trait in lib.rs should be used, as dash-pkc does.

Additional Information

dash-types already had a crate-wide sealed module, but only under codec, while serialize is gated on serde alone. This pull request declares the module once at the top of lib.rs, under codec or serde, and str_u64::Value now uses it.

The integer impls move into that module too: CompactUint (under codec) and str_u64::Value (under serde) both need Sealed for u64, so an impl next to each trait would conflict with both features on. compact.rs keeps the CompactUint impls and drops its impl Sealed.

Breaking Changes

None. CompactUint and str_u64::Value stay sealed, and the sealed module stays private.

How Has This Been Tested?

• cargo clippy -p dash-types --all-targets -- -D warnings is clean with no features, serde, the defaults (codec), full, and serde,std.
• cargo test -p dash-types --all-features passes.
• CI (just test lint fuzz::test, CodeQL included) is green.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional tests
• I have made corresponding changes to the documentation
• I did not use agentic assistance (i.e. LLMs, AI) except as disclosed and can answer questions,
  comments and concerns without said assistance. I assume authorship of the code submitted.
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Agent disclosure

Code, commit messages and this description were generated with Claude Code using Claude Opus 5.5, running autonomously as an agent on behalf of the author. The change was reviewed by a Claude Code agent using Opus 5.5 and a Codex agent using GPT-6.1.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: dashpay/base-sdk
• Branch: pasta/types-sealed
• File: .coderabbit.yml
• Commit: 500ca5b
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 958ebd15-9203-4427-b90a-05676f7ed782

Commits

Reviewing files that changed from the base of the PR and between 751f042 and 500ca5b.

Files selected for processing: 3

• pkgs/types/src/compact.rs
• pkgs/types/src/lib.rs
• pkgs/types/src/serialize.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[thepastaclaw]

✅ Final review complete — no blockers (commit 500ca5b) · triage: low

[github-actions]

Note

This pull request has no conflicts! 🎊 🎉 🎊

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[thepastaclaw]

Final validation — Phase 1 + Phase 2

Verified the complete base-to-head diff at 500ca5b and confirmed the reviewers' clean assessment: the shared private sealing trait preserves supported implementations and serialization behavior, with correct gating for codec-only, serde-only, combined, and neither-feature configurations. Validation was static only; no builds or tests were run locally. Current CI has no failed checks, with lint, stable-platform checks, and several MSRV jobs passing; Ubuntu, cross-platform builds, and additional MSRV work remain pending.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: glm-5.3-flash (agent: phase1-reviewer, role: rust-quality); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

• Triage: low by gpt-6.1-sol (effort low) — This small, contained refactor consolidates private sealing traits and integer implementations with straightforward feature gating and no intended runtime behavior change.
• Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer, glm-5.3-flash — rust-quality (completed, effort high); agent phase1-reviewer
• Phase 1 model: glm-5.3-flash — zai quota: 5h 100% left, weekly 57% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
• Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
• Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort medium); agent phase2-reviewer

[kwvg]

utACK 500ca5b