Skip to content

primitives%doc: wrap the netinfo.json5 heading at 80 columns - #103

Merged
PastaPastaPasta merged 1 commit into
developfrom
pasta/netinfo-corpus-heading
Nov 1, 2026
Merged

PastaPastaPasta merged 1 commit into
developfrom
pasta/netinfo-corpus-heading

Conversation

@PastaPastaPasta

Copy link
Copy Markdown
Member

Motivation

Follows up on #87 (comment). The heading of pkgs/primitives/corpus/netinfo.json5 ran its paragraphs on single long lines, so it was hard to read in an editor without word wrap.

Additional Information

The heading comment is rewrapped at 80 columns in the style of block_check.json5, with a blank line before the data. The text is unchanged apart from line breaks. The program blocks and the vectors are untouched.

How Has This Been Tested?

  • cargo test -p dash-primitives --all-features netinfo passes.
  • CI (just test lint fuzz::test, CodeQL included) is green.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional tests
  • I have made corresponding changes to the documentation
  • I did not use agentic assistance (i.e. LLMs, AI) except as disclosed and can answer questions,
    comments and concerns without said assistance. I assume authorship of the code submitted.
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Agent disclosure

Code, commit messages and this description were generated with Claude Code using Claude Opus 5.5, running autonomously as an agent on behalf of the author. The change was reviewed by a Claude Code agent using Opus 5.5 and a Codex agent using GPT-6.1.

🤖 Generated with Claude Code

@PastaPastaPasta PastaPastaPasta added this to the 0.3 milestone Nov 1, 2026
@PastaPastaPasta
PastaPastaPasta requested a review from kwvg November 1, 2026 01:48
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • pkgs/primitives/corpus/netinfo.json5 is excluded by !**/*.json5

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@thepastaclaw

thepastaclaw commented Nov 1, 2026 •

Copy link
Copy Markdown

✅ Final review complete — Phase 1 only — no blockers (commit 6c5044d) · triage: trivial

@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

Note

This pull request has no conflicts! 🎊 🎉 🎊

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review — Phase 1 only (trivial change)

Verified the exact head 6c5044d against the supplied base: the change only rewraps the heading and adds a blank line, preserving its wording and leaving the vectors and generator programs byte-identical. No actionable findings were supplied or identified; current CI shows lint and completed build/test checks passing, with several platform and MSRV checks still pending. The failed “Comment on pull requests” check is unrelated automation, not a code check; no builds or tests were run locally.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: final-verifier)

  • Triage: trivial by gpt-6.1-sol (effort low) — The diff only rewraps heading comments and adds a blank line in pkgs/primitives/corpus/netinfo.json5, leaving executable content and test vectors unchanged.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 99% left, weekly 57% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-gate-verifier
  • Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves

@PastaPastaPasta
PastaPastaPasta merged commit 889aea0 into develop Nov 1, 2026
52 of 53 checks passed
@kwvg
kwvg deleted the pasta/netinfo-corpus-heading branch November 1, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants