[kwvg]

Additional Information

• Depends on refactor: drop fMasternodeMode global, create new context for masternode mode-only logic (ActiveContext), move spun-off signers and EHF signals handler #6828

• Depends on fix: use std::atomic to protect connected manager/signer pointers, check before queueman access, update P2P message map in tests #6842

• Depends on chore!: merge bitcoin#28753, partial bitcoin#28195 (bump MIN_PEER_PROTO_VERSION to 70221) #6877

• Dependency for refactor: update lock annotations for CGovernanceObject and GovernanceStore, move away from RecursiveMutexes #6849

• To reduce the proliferation of PeerManager in governance logic, relaying has been centralized to CGovernanceManager and now done through a scheduled task that processes a queue of requests. This reduces the amount of code that needs to fetch a reference to PeerManager in order to queue a message for relay and brings us closer to dropping it as a member in other objects.

  • On test chains, the queue of requests is processed every second but on mainnet, it is processed every 5 seconds. This is because functional tests assume instantaneous relay and fail if it takes too long to relay messages (as cascading delays cause test timeout).

• Likewise, to reduce the references to CActiveMasternodeManager, signing logic is consolidated to SignBasic() with the objects using simple getter/setters (or direct assignment) where applicable.

Breaking Changes

None expected.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation (note: N/A)
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)