[PastaPastaPasta]

Issue being fixed or feature implemented

Before every major release, doc/release-process.md asks for fresh seeds, checkpoints, nMinimumChainWork, defaultAssumeValid, chainTxData and assumed sizes for mainnet and testnet. The current values date from v23.x: mainnet block 2487500, testnet block 1400000. This PR updates them for v24.0.0. As with #6920 for v23, it goes to develop first, then to v24.0.x as a backport.

What was done?

Seeds (contrib/seeds/*, src/chainparamsseeds.h)

• Mainnet: 239 IPv4 seeds and 10 onion seeds, generated from protx list valid true 2563000 with makeseeds.py -a asmap-filled.dat (asmap from bitcoin.sipa.be, sha256 eab9c6e00769b461bf5c0cd02c7b5e991739ebbbff3ce568846377031f4b5fcf). makeseeds reported 2252 masternodes, 2207 with at least 10000 confirmations, and 1507 after deduplication. The per-ASN limit then reduced that to 239.
• Testnet: 25 seeds from protx list valid true 1581000. As in chore: update minimum chain work, tx stats, checkpoints, seeds and SECURITY.md for v23 #6920, operator deduplication was commented out and the IPv4 per-ASN limit raised to 10. These are local edits and are not committed.
• onion_seeds.txt: removed the 15 onion addresses that failed two nc -z attempts through Tor. The remaining 10 all answered.
• contrib/seeds/README.md: the example now uses protx list valid true <height>. v24 rejects 1 for detailed unless -deprecatedrpc=permissive_bool is set.

Chain parameters (src/kernel/chainparams.cpp)

	Mainnet	Testnet
Block	2563000	1550000 (about 32k blocks behind the tip, as release-process.md asks)
Hash (new checkpoint, defaultAssumeValid)	000000000000000346a1804da4832b0b69dd9a7f96b14c7cb54585a9ac6ae98f	000000116cd3c11d44c88cbc0a26804bd277a5d790f684ec3a8aaa820690318c
nMinimumChainWork	0x…c15981a81af44a6abe1a	0x…03ed573a939487fc
chainTxData (getchaintxstats 17280 <hash>)	1793218693 / 71411418 / 0.1306891420721072	1788899589 / 8494561 / 0.0139463532250889
m_assumed_blockchain_size	57 → 62	10 (unchanged)
m_assumed_chain_state_size	1 (unchanged)	1 (unchanged)

Sizes:

• Mainnet: a synced v24.0.0-rc.4 datadir is 56G. With 10% headroom that gives 62. The chainstate is 258M, so the chain state size stays at 1.
• Testnet: the synced datadir is 6.3G, below the current value of 10, so that value is kept. The chainstate is 111M.

m_assumeutxo_data is still empty on mainnet and testnet. There is no published snapshot to commit to yet.

Reviewers can reproduce every value with getblockhash, getblockheader and getchaintxstats 17280 <hash> at the heights above, and the seed lists with the README commands at the stated heights.

How Has This Been Tested?

• All values were read from fully synced v24.0.0-rc.4 mainnet and testnet nodes: block 2563000 had 586 confirmations, the mainnet tip was 2563584, and the testnet tip was 1581864.
• Built this branch and ran the versionbits_tests, validation_tests, validation_chainstatemanager_tests, net_tests and checkqueue_tests unit tests: no errors.
• Started this branch's dashd on empty mainnet and testnet datadirs with -dnsseed=0, so it could only bootstrap from the new fixed seeds.
  • Mainnet: logged "Added 239 fixed seeds", reached 10 peers, and synced headers to 2563592.
  • Testnet: logged "Added 25 fixed seeds", reached 10 peers, and synced headers to 1581891.
  • Both header syncs passed the new checkpoints with no checkpoint or bad-fork errors. The onion seeds were not used in this run because Tor was off.
• Mainnet EHF check, done on a fully synced v24.0.0-rc.4 node at tip 2563584: a scan of every block from V20 activation (1987776) to the tip, 575810 blocks, found exactly three MNHF_SIGNAL transactions. They are bit 10 at 2119135 (MN_RR), bit 11 at 2192864 (WITHDRAWALS), and bit 12 at 2400222. The bit-12 signal is the one v23's numbering mined for V24, and is why V24 moved to bit 13. None is for bit 13 or 14, and no block in the last 4032 sets version bit 12, 13 or 14. v24 has no deployment on bit 12, so v24 nodes see that old signal as an unknown bit. The Nov 9 signal is therefore the first bit-13 signal for v23 and v24 nodes alike, with no duplicate or expired-signal mismatch. rc.4's getdeploymentinfo omits NEVER_ACTIVE deployments, so the chain was checked directly instead.

Breaking Changes

None.

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone

🤖 Generated with Claude Code

[coderabbitai]

Walkthrough

The documented seed-generation command and the mainnet, testnet, and onion seed inventories were updated. The serialized mainnet and testnet seed arrays were refreshed. Mainnet and testnet chain-work, assume-valid, checkpoint, and transaction-statistics values were advanced. The assumed mainnet blockchain size also increased.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~12 minutes

Possibly related PRs

• dashpay/dash#7925: Updates the seed-generation workflow and generated seed outputs.
• dashpay/dash#7940: Changes service-flag checks for hardcoded seed addresses.
• dashpay/dash#7973: Also changes src/kernel/chainparams.cpp for the v24 mainnet release.

Merge Risk: Low · up to bcf12

The release metadata does not follow the documented transaction-statistics procedure; align the values with the 4096-block window or document and justify the exception before release.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title names the main change: updates to seeds, checkpoints, minimum chain work, assumevalid and tx stats for v24. The changeset matches this. The diff updates contrib/seeds files, src/chainparamss…
Description check		The description matches the changeset. It explains the release-driven refresh of seeds, checkpoints, nMinimumChainWork, defaultAssumeValid, chainTxData and assumed sizes for mainnet and testnet. It li…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the main change: updates to seeds, checkpoints, minimum chain work, assumevalid and tx stats for v24. The changeset matches this. The diff updates contrib/seeds files, src/chainparamsseeds.h, and src/kernel/chainparams.cpp with the new mainnet and testnet values. The title uses the 'chore:' prefix and is 86 characters long, which is somewhat long but still clear.

Full details: Description check

Explanation

The description matches the changeset. It explains the release-driven refresh of seeds, checkpoints, nMinimumChainWork, defaultAssumeValid, chainTxData and assumed sizes for mainnet and testnet. It lists the affected files (contrib/seeds/*, src/chainparamsseeds.h, src/kernel/chainparams.cpp), the new block heights and hashes, the onion seed pruning, the README command change, and the testing performed.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (4 skipped: 4 unsupported.)

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-29T22:02:13.851697Z We couldn’t complete this review. Comment @codex review to try again.	b34f8c7	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[thepastaclaw]

🕓 Review not started yet because the new head is waiting for the 30-minute push debounce.

• Request normal review — click when the PR is ready for review.
• Request priority review — click to move this review to the front of the queue.

Commit bcf1202. Normal review starts when eligible; priority review starts as soon as a slot is available.

[thepastaclaw]

Final validation — Phase 1 + Phase 2

The release metadata and generated seed data are internally consistent, but the reproducibility documentation is incomplete. The transaction-statistics values use a 17280-block window even though the release process requires 4096, and the seed-generation instructions omit the special testnet procedure and leave stale RPC examples in makeseeds.py. CI formatting and lint checks passed; platform build checks were still queued in the supplied snapshot.

🟡 3 suggestion(s)

2 finding(s) not shown inline (the lines are not part of this PR's diff)

🟡 Suggestion: Document the non-default testnet seed-generation procedure
contrib/seeds/README.md:6-22

The README documents only the mainnet command at height 2563000, but the PR generates testnet seeds at height 1581000 using local, uncommitted changes that disable operator deduplication and raise the IPv4 per-ASN limit to 10. The committed nodes_test.txt contains ten entries from each of AS205581 and AS16610, whereas the checked-in makeseeds.py defaults to four IPv4 seeds per ASN. Add a reproducible testnet command and document the required settings, or provide a supported command-line option for them.

_{source: gpt-6-astra (phase2-reviewer: general)}

🟡 Suggestion: Update stale RPC examples in makeseeds.py
contrib/seeds/makeseeds.py:6-7

The README now correctly uses protx list valid true <height> because v24 rejects the numeric 1 for the detailed argument without the permissive_bool compatibility option, but makeseeds.py still documents protx list valid 1 in its header, argparse help text at line 157, and explanatory comment at line 169. Maintainers following the script's own documentation will use a rejected RPC form and cannot reproduce the seed list under v24 defaults. Update all three occurrences to the boolean form.

_{source: muse-spark-1.3-contributor (phase1-reviewer: general)}

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); reviewer 3: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 4: gpt-6-astra (agent: phase2-reviewer, role: general); reviewer 5: gpt-6-astra (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

• Triage: critical by gpt-6.1-sol (effort low) — The large update changes consensus-sensitive validation and chain-selection parameters in src/kernel/chainparams.cpp, including checkpoints, nMinimumChainWork, and defaultAssumeValid, as well as peer bootstrap seed data.
• Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer
• Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
• Single stage: Phase 1 and Phase 2 reviewed this head side by side, with no blocker gate between them (triage tier)
• Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
• Phase 2 reviewers: gpt-6.1-sol — general (completed, effort xhigh); agent phase2-reviewer, gpt-6.1-sol — dash-core-commit-history (completed, effort xhigh); agent phase2-reviewer, gpt-6-astra — general (completed, effort xhigh); agent phase2-reviewer, gpt-6-astra — dash-core-commit-history (completed, effort xhigh); agent phase2-reviewer
• Model comparison: every Phase-2 reviewer also ran on gpt-6-astra; the verifier weighed both sets without knowing which model wrote which

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `src/kernel/chainparams.cpp`:
- [SUGGESTION] src/kernel/chainparams.cpp:368-373: Use the documented transaction-statistics window
  Both updated chainTxData entries are documented as `getchaintxstats 17280`, while doc/release-process.md explicitly requires a 4096-block window for major releases. The resulting dTxRate feeds GuessVerificationProgress, so this changes the synchronization-progress estimate and prevents reviewers from reproducing the values using the documented procedure. Recalculate both entries with the required window, or update the release process to document and justify the Dash-specific 17280-block convention.

In `contrib/seeds/README.md`:
- [SUGGESTION] contrib/seeds/README.md:6-22: Document the non-default testnet seed-generation procedure
  The README documents only the mainnet command at height 2563000, but the PR generates testnet seeds at height 1581000 using local, uncommitted changes that disable operator deduplication and raise the IPv4 per-ASN limit to 10. The committed nodes_test.txt contains ten entries from each of AS205581 and AS16610, whereas the checked-in makeseeds.py defaults to four IPv4 seeds per ASN. Add a reproducible testnet command and document the required settings, or provide a supported command-line option for them.

In `contrib/seeds/makeseeds.py`:
- [SUGGESTION] contrib/seeds/makeseeds.py:6-7: Update stale RPC examples in makeseeds.py
  The README now correctly uses `protx list valid true <height>` because v24 rejects the numeric `1` for the detailed argument without the permissive_bool compatibility option, but makeseeds.py still documents `protx list valid 1` in its header, argparse help text at line 157, and explanatory comment at line 169. Maintainers following the script's own documentation will use a rejected RPC form and cannot reproduce the seed list under v24 defaults. Update all three occurrences to the boolean form.

[thepastaclaw]

🟡 Suggestion: Use the documented transaction-statistics window

Both updated chainTxData entries are documented as getchaintxstats 17280, while doc/release-process.md explicitly requires a 4096-block window for major releases. The resulting dTxRate feeds GuessVerificationProgress, so this changes the synchronization-progress estimate and prevents reviewers from reproducing the values using the documented procedure. Recalculate both entries with the required window, or update the release process to document and justify the Dash-specific 17280-block convention.

_{source: gpt-6-astra (phase2-reviewer: general)}

[PastaPastaPasta]

approved