Skip to content

docs: e2e test architecture and legacy JS retirement plans (draft, not for merge) - #5763

Draft
shumkov wants to merge 1 commit into
v5.1-devfrom
shumkov/v51-e2e-specs-draft
Draft

shumkov wants to merge 1 commit into
v5.1-devfrom
shumkov/v51-e2e-specs-draft

Conversation

@shumkov

@shumkov shumkov commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Draft for discussion. Not meant to be merged. It holds the working plans for the end-to-end test system and the legacy JS retirement, so they can be reviewed with line comments. When the work starts, the plans turn into issues and implementation PRs, and this PR is closed.

What is in here

  • docs/E2E_TEST_ARCHITECTURE_SPEC.md (revision 3) and its plain-language walkthrough: one e2e test system for Platform and every SDK.
  • docs/LEGACY_JS_RETIREMENT_SPEC.md and its walkthrough: retiring the legacy JS stack (dash SDK, wallet-lib, js-dapi-client, wasm-dpp, dashcore-lib) and the old platform-test-suite. The e2e part of this plan is superseded by the e2e spec; the rest still stands as a track inside it.

The plan in short

  • Platform behaviour is tested once, in Rust, against a real network. Every SDK we ship is a layer over the Rust SDK (JS through wasm, Swift and Kotlin through FFI), so each SDK only proves its own layer: offline by replaying recorded real responses, live with a small smoke test.
  • Four levels: unit and in-process tests; protocol e2e in a new Rust crate (rs-platform-e2e) on the local dashmate network; recorded read fixtures replayed by every SDK through Rust; a small live smoke per SDK.
  • One configuration for every SDK (DASH_E2E_* keys written by the existing setup) and one funding model.
  • Built on test(platform-wallet): e2e framework + full test suite — triage pins, Found-*/PA-* guards, fail-closed persist, Stage-2 merge #3549's wallet-free core (about 2k lines, credited to its author), not from scratch: it already solves the shared runtime, stack size, contract registration, commit-wait and lagging-node problems. test(platform-wallet): e2e framework + full test suite — triage pins, Found-*/PA-* guards, fail-closed persist, Stage-2 merge #3549's wallet layer lands later on the same core.
  • The legacy platform-test-suite is deleted after parity: 73 cases ported, 5 already covered elsewhere, 17 dropped with a reason each (§8).
  • Phases: E1 network smoke on consensus PRs; E2 crate, framework, smoke set and CI; E3–E6 the families to parity, then delete the legacy suite; fixtures in parallel; SDK smoke alignment; E7–E9 tokens/groups/voting, remote runs, the wallet layer. Rough effort and CI cost are in §9 and §11.

Decisions so far

Open

🤖 Generated with Claude Code

… discussion)

Working plans for review only; this branch is not meant to be merged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added this to the v5.1.0 milestone Nov 4, 2026
@thepastaclaw

Copy link
Copy Markdown
Collaborator

🕓 Review not started yet because this PR is a draft.

  • Request normal review — click when the PR is ready for review.
  • Request priority review — click to move this review to the front of the queue.

Commit d571beb. Normal review starts when eligible; priority review starts as soon as a slot is available.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants