[QuantumExplorer]

Basic explanation

What this does: drive's tests compile again on v5.1-dev. One test call passed an argument that a function no longer takes; this PR removes it.

Why it broke: two PRs merged close together and conflict in meaning, not in text.

• feat(platform): price storage refunds at the storing epoch's rate and drop the fee history map #5798 (dd9dc7e) removed a parameter from Drive::add_document_for_contract.
• refactor(sdk): check document requests with Drive's own request-only planning before sending #5774 (ccaa396), merged just after, added packages/rs-drive/src/query/proof_plan_equivalence_tests.rs, whose fixture still passes it.

Each PR's CI ran without the other's change.

Value: the Clippy lints step (cargo clippy -p drive --all-targets) fails on v5.1-dev and on every PR against it until this lands.

Risks: none. It changes one test fixture only.

Issue being fixed or feature implemented

cargo clippy -p drive --all-targets --all-features -- -D warnings   (on v5.1-dev ccaa396b76)
  before: error[E0061]: this method takes 6 arguments but 7 arguments were supplied
          --> packages/rs-drive/src/query/proof_plan_equivalence_tests.rs:106:14
  after:  Finished, no warnings

What was done?

The fixture's add_document_for_contract(..) call in proof_plan_equivalence_tests.rs drops the trailing None that #5798 removed from the signature. No other call site passes it.

How Has This Been Tested?

On v5.1-dev ccaa396 with this change:

• cargo clippy -p drive --all-targets --all-features -- -D warnings: clean.
• cargo check -p drive-abci --tests: compiles.
• No other uses of the APIs feat(platform): price storage refunds at the storing epoch's rate and drop the fee history map #5798 changed (add_document_for_contract, lookup_cost, from_storage_removal) were left stale.

Breaking Changes

None.

Checklist:

• I have performed a self-review of my own code
• My Rust, FFI, WASM, Swift or Kotlin changes follow the coding conventions
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed
• If I added or changed GroveDB structure, I described it in the area's structure.rs, regenerated grovedb-structure.json, and checked the structure viewer link posted on this pull request
• If I added or changed a system contract's document schemas, I checked the contract viewer link posted on this pull request

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

🤖 Generated with Claude Code

PR Hygiene · f4c9ff4

• Bots — thepastaclaw not yet — /skip-bots proceeds without the ones not yet reported
• Self-review — post /self-reviewed
• Build running
• Approvals — you own every area touched; none needed

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

• Tests
  • Updated a test setup call to match the current document-adding interface.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The populated_drive setup in the proof plan equivalence tests no longer passes the None argument after true to add_document_for_contract.

Changes: Proof plan equivalence tests

Layer / File(s)	Summary
Update document setup call packages/rs-drive/src/query/proof_plan_equivalence_tests.rs	The add_document_for_contract call no longer passes None after true.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: shumkov

Merge Risk: Minimal · up to f4c9f

This narrowly scoped test-call update has no identified merge-blocking risk and is ready to merge subject to normal checks.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title names the change: it removes an argument that PR #5798 dropped from add_document_for_contract, in a proof plan test. The raw summary confirms the only change is removing the trailing None fr…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the change: it removes an argument that PR #5798 dropped from add_document_for_contract, in a proof plan test. The raw summary confirms the only change is removing the trailing None from that call in proof_plan_equivalence_tests.rs. The title matches the main change and the objectives, which describe restoring compilation on v5.1-dev.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: dashpay/platform
• Branch: fix/proof-plan-test-add-document-arguments
• File: .coderabbit.yaml
• Commit: f4c9ff4
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: b7461253-025f-435b-b542-4fc6b0e6d8e1

Commits

Reviewing files that changed from the base of the PR and between ccaa396 and f4c9ff4.

Files selected for processing: 1

• packages/rs-drive/src/query/proof_plan_equivalence_tests.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[github-actions]

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

[thepastaclaw]

🕓 Review not started yet because the new head is waiting for the 30-minute push debounce.

• Request normal review — click when the PR is ready for review.
• Request priority review — click to move this review to the front of the queue.

Commit f4c9ff4. Normal review starts when eligible; priority review starts as soon as a slot is available.