[xdustinface]

Split out of #1227. Three small cleanups in the masternode storage, independent of the snapshot codec:

• Drop the unused headers field of PersistentMasternodeStorage.
• Truncate the masternode engine only through storage. The client truncated the engine after StorageManager::truncate_above, which truncated the same shared engine again. Storage now runs the engine step even when the chain steps fail, and the client no longer repeats it.
• Document which heights get_quorum_at_height resolves.

PR Hygiene · 122c133

• Bots — coderabbitai skipped by xdustinface
• Self-review — posted; again after any push
• Build green
• Approvals — you own every area touched; none needed

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: dashpay/rust-dashcore
• Branch: refactor/masternode-storage-cleanup
• File: .coderabbit.yaml
• Commit: 122c133
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1808a04e-a59e-4e1a-8f07-09ad0dfd0a72

Commits

Reviewing files that changed from the base of the PR and between 50a97a3 and 122c133.

Files selected for processing: 4

• dash-spv/src/client/lifecycle.rs
• dash-spv/src/client/queries.rs
• dash-spv/src/storage/masternode.rs
• dash-spv/src/storage/mod.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

[github-actions]

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.05%. Comparing base (50a97a3) to head (122c133).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1246      +/-   ##
==========================================
- Coverage   79.06%   79.05%   -0.02%     
==========================================
  Files         298      298              
  Lines       79058    79057       -1     
==========================================
- Hits        62506    62495      -11     
- Misses      16552    16562      +10     

Flag	Coverage Δ
core	77.85% <ø> (ø)
ffi	52.96% <ø> (-0.01%)	⬇️
rpc	52.05% <ø> (ø)
spv	93.46% <100.00%> (-0.05%)	⬇️
wallet	82.49% <ø> (ø)

Files with missing lines	Coverage Δ
dash-spv/src/client/lifecycle.rs	93.84% <100.00%> (-0.10%)	⬇️
dash-spv/src/client/queries.rs	37.83% <ø> (ø)
dash-spv/src/storage/masternode.rs	98.20% <100.00%> (-0.04%)	⬇️
dash-spv/src/storage/mod.rs	90.42% <100.00%> (+0.16%)	⬆️

... and 2 files with indirect coverage changes

[xdustinface]

/skip-bots

[xdustinface]

/self-reviewed

[github-actions]

Policy satisfied — this can merge.
Full checklist in the description.