[xdustinface]

Clippy with --all-targets (the pre-push hook) fails on dev with two compile errors in test code.

• dash/src/network/message.rs: refactor!: remove BIP141 (SegWit) and BIP341 (Taproot) support #400 removed NetworkMessage::WtxidRelay, and feat(dash-spv): Add BIP324 v2 encrypted P2P transport #264 merged right after with a test that still lists it. Each PR was green alone. This drops the stale entry.
• key-wallet/src/bip32.rs: the test_matrix from refactor!: drop dashcore_hashes::hex in favour of hex-conservative, ban hex{,_lit,-literal} with cargo deny #1110 generates colliding test names under test-case 3.3.x, which lowercases and strips the 0x/0X and ""/' inputs. 3.4.0 numbers each case so the names stay unique. Every crate declared test-case = "3.3", so a local Cargo.lock still on 3.3.1 fails to compile while CI resolves 3.4.1. This raises the minimum to "3.4" in all seven crates.

PR Hygiene · 0f0d814

• Bots — coderabbitai ✓
• Self-review — post /self-reviewed
• Build running
• Approvals — you own every area touched; none needed

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

• Chores
  • Updated internal test tooling across several components.
• Tests
  • Adjusted message-validation checks. No user-facing functionality or behavior changes are included in this update.

[github-actions]

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: dashpay/rust-dashcore
• Branch: fix/pre-commit-dev
• File: .coderabbit.yaml
• Commit: 0f0d814
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8e596c82-0af7-4e33-afa4-a345ba427f30

Commits

Reviewing files that changed from the base of the PR and between f28a414 and 0f0d814.

Files selected for processing: 8

• dash-network/Cargo.toml
• dash-spv/Cargo.toml
• dash/Cargo.toml
• dash/src/network/message.rs
• hashes/Cargo.toml
• key-wallet-ffi/Cargo.toml
• key-wallet/Cargo.toml
• rpc-client/Cargo.toml

Files with no reviewable changes: 1

• dash/src/network/message.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Seven crate manifests update the test-case dev-dependency from 3.3 to 3.4. A network message test removes WtxidRelay from the messages checked for empty payloads.

Changes: Test dependency and message test updates

Layer / File(s)	Summary
Update test dependency versions dash-network/Cargo.toml, dash-spv/Cargo.toml, dash/Cargo.toml, hashes/Cargo.toml, key-wallet-ffi/Cargo.toml, key-wallet/Cargo.toml, rpc-client/Cargo.toml	The manifests update the test-case dev-dependency from version 3.3 to 3.4.
Adjust empty-payload message test dash/src/network/message.rs	The test no longer includes NetworkMessage::WtxidRelay among messages whose payloads are asserted to be empty.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: zocolini, pastapastapasta

Merge Risk: Minimal · up to 0f0d8

No actionable merge-blocking risk was identified.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main change: fixing test-target compilation issues so Clippy runs again on dev targets.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (7 skipped: 7 unsupported.)

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[github-actions]

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.86%. Comparing base (f28a414) to head (0f0d814).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1287      +/-   ##
==========================================
- Coverage   82.09%   81.86%   -0.24%     
==========================================
  Files         184      291     +107     
  Lines       58187    76393   +18206     
==========================================
+ Hits        47769    62538   +14769     
- Misses      10418    13855    +3437     

Flag	Coverage Δ
core	81.10% <ø> (?)
ffi	60.10% <ø> (ø)
rpc	52.10% <ø> (ø)
spv	93.85% <ø> (+0.01%)	⬆️
wallet	83.07% <ø> (ø)

Files with missing lines	Coverage Δ
dash/src/network/message.rs	92.58% <ø> (ø)

... and 111 files with indirect coverage changes