[xdustinface]

Block getdata went to the peer least loaded relative to its cap. A slow peer at the minimum cap can hold 5 to 30 s of work, so a block the filter rescans wait on could sit behind it while a fast peer had room. The filters manager processes blocks in height order, so one late block holds back every block above it.

Block requests now go to the peer with the shortest expected queue, in_flight / serving_rate, which #1349 introduced for header requests, with the same cap ratio fallback while a busy peer has no serving rate yet. Bulk filter traffic keeps the cap ratio. route_picks_the_peer_by_class gains the two block cases.

Summary by CodeRabbit

• Bug Fixes
  • Peer selection for header and block requests now favors the shortest serving wait when rate measurements are available, with a fallback to the existing in-flight comparison when they are not.

PR Hygiene · 8aa6300

• Bots — coderabbitai ✓
• Self-review — posted; again after any push
• Build green
• Approvals — you own every area touched; none needed

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

choose_peer now uses serving wait time for both header and block requests. When a busy candidate lacks a measured serving rate, selection falls back to the existing cap-relative in-flight comparison. Tests cover both block-request selection paths.

Changes: Peer Selection

Layer / File(s)	Summary
Request routing and validation dash-spv/src/network/broker.rs	The preferred wait-time selection now applies to header and block requests. The documentation also describes bulk filter traffic. Tests cover shortest-queue selection for block requests and the cap-ratio fallback when a busy peer has no measured serving rate.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: zocolini

Merge Risk: Minimal · up to 8aa63

Block routing now uses estimated queue time. No actionable merge-blocking risk was established; retry the failed CI setup checks.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title "fix(dash-spv): route block requests to the shortest queue" matches the main change. The broker's choose_peer now picks the peer for block requests by serving wait time (in_flight / serving_…
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "fix(dash-spv): route block requests to the shortest queue" matches the main change. The broker's choose_peer now picks the peer for block requests by serving wait time (in_flight / serving_rate). It falls back to the cap-relative comparison when a busy peer has no serving-rate measurement. The title is specific, short, and follows a conventional commit style. It names the scope (dash-spv) and the behavior change.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 1 files.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: dashpay/rust-dashcore
• Branch: fix/block-requests-shortest-queue
• File: .coderabbit.yaml
• Commit: 8aa6300
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 03c2b8f6-f5b9-41aa-b632-7bd187a85969

Commits

Reviewing files that changed from the base of the PR and between 451c6cc and 8aa6300.

Files selected for processing: 1

• dash-spv/src/network/broker.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.36%. Comparing base (451c6cc) to head (8aa6300).

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #1365   +/-   ##
=======================================
  Coverage   85.35%   85.36%           
=======================================
  Files         268      268           
  Lines       68948    68948           
=======================================
+ Hits        58853    58856    +3     
+ Misses      10095    10092    -3     

Flag	Coverage Δ
core	82.42% <ø> (ø)
rpc	52.10% <ø> (ø)
spv	94.23% <100.00%> (+0.01%)	⬆️
wallet	83.39% <ø> (ø)

Files with missing lines	Coverage Δ
dash-spv/src/network/broker.rs	98.50% <100.00%> (ø)

... and 3 files with indirect coverage changes

[xdustinface]

/self-reviewed

[github-actions]

Waiting for bot review — coderabbitai not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

[github-actions]

Policy satisfied — this can merge.
Full checklist in the description.