Repository navigation
fix(contracts): carry activityLogged description as summary - #245
Merged
Merged
Conversation
…ows show text buildActivity hardcoded summary: undefined, discarding the description field the backend sends on every activityLogged frame. The work-log heading chain derives row text from activity.summary, and provider_* activities carry no tool_name/command payload for the fallback extractors, so their timeline rows rendered icon-only. Populate summary from the payload description (trimmed, non-empty string only). Provider skill/subagent/reasoning/explore rows now show 'Skill dispatched: ...' etc. next to their icons.
Extend from 2 dialog tests to 13 covering every invoke<T>() site: terminal IPC (spawn, resize, write, kill, read, alive, dispose) and shell.openInEditor including the window.open fallback and non-command error rethrow paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildActivityhardcodedsummary: undefined, discarding thedescriptionfield sent on everyactivityLoggedwire frame. The work-log heading chain derives all row text fromactivity.summary, andprovider_*activities (reasoning/skill/subagent/explore) carry notool_name/commandfields for the fallback extractors — so their timeline rows rendered icon-only with empty text.summaryfrom the payloaddescription(trimmed, non-empty only; otherwiseundefined).tauriNativeApi.tscovering all 6 realinvoke<T>()call sites (from 2 → 13 tests).Test plan
vitest runfull suite: 2234/2235 (1 pre-existing unrelatedwsTransportport failure)tsc --noEmitclean🤖 Generated with Claude Code