Repository navigation
Tidy agent names and the collapse toggle in the Workshop sidebar - #1818
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1817
Summary
Agent names
spaninstead of<span><strong>…</strong></span>. Thestrongdates from the first sidebar, where each agent row had a bold name over a "coding agent" caption; the caption went away and the bold stayed..agent-linkgets the 0.8rem size.channel-linkuses, so agent names match channel and direct message names. The unused.agent-link strongand.agent-link smallselectors are removed (the.sidebar-footerrules they shared are kept).Collapse toggle
nav-tool-button sidebar-toggle, so like every other sidebar icon button it shows its outline only on hover or keyboard focus. The old.sidebar-togglerules, which drew a permanent--color-border-strongborder, are removed.ChevronIconinicons.tsx. The glyph sat off-center in its line box, so it never centered vertically; the SVG fills the button and centers exactly.Testing
npm run typecheckclean.npx vitest run: 289 passed, including new checks that the toggle is anav-tool-buttonwith an SVG and no text, and that the agent row has nostrong.npm run verify-generatedclean.