Repository navigation
Match Workshop dialog and detail panel headers to the panes - #1822
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1821
Summary
Dialogs and detail panels now use the same header as the panes: one title line in the "Kai Workshop" label style, centered with its actions, and the sidebar's icon buttons.
Titles. The context line above each title is gone. Where it carried meaning, it is folded into the title:
Everywhere else the existing title stays and the context line is dropped (for example "Create channel", "Continue?", "Help and actions", "Review pull request", "Create workspace", the selected workspace or job name, "Fact"/"Episode", "Which version is true?"). Where a dropped line said something the dialog body did not, the title now says it.
Styles (
styles.css).channel-archive-header,.workspace-creation-header,.agent-creation-header,.action-palette > header,.review-dialog > header,.memory-editor > header) center their title and actions. Shared rules with.review-list > liand.agent-section-headingwere split so those keep their top alignment.Icons
nav-tool-button, so they match the side panel icons. Close and back useCloseIconandBackIconfromicons.tsxinstead of text glyphs..channel-archive-actions svg,.workspace-creation-header .panel-icon-button svg).Testing
npm run typecheckclean.npx vitest run: 289 passed. Dialog lookups use the new titles, and the agent creation and memory editor tests expectnav-tool-buttonwith an SVG close icon.npm run verify-generatedclean.