Repository navigation
test(fixtures): give the agenda fixture a split-slot room - #20
Merged
Merged
Conversation
Upstreamed from dddwa/dddperth#166. The fixture timetable was a uniform rectangle — five rooms moving in lockstep through five identical slots. That made a session's time *slot* and its time *span* interchangeable, so anything relying on that equivalence looked correct against the fixture while being wrong on a real conference day: a 45 minute talk genuinely does run against two separate 20 minute talks in another room. Adds a sixth room (Pelican Room) running 2x20 minute talks inside the first two long slots, plus the `20 mins` session format the real taxonomy would carry. One long talk now overlaps two short talks living in different `timeSlots` entries, so slot identity and interval overlap give different answers and code confusing the two fails. The short track's gaps are deliberately not service sessions: the existing Changeover entries are `isPlenumSession: true`, meaning venue-wide, and a changeover in one room while every other room is mid-talk is not that. Also drops an editing note pointing at `nx generate-sessionize-fixtures` — no such target exists; the views are projected in memory by `sessionize-server.ts`. Baselines are this repo's own, regenerated against conference-stub in the pinned Playwright container — the fork's conference-branded ones were deliberately not copied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstreamed from dddwa/dddperth#166 (merged).
What
Gives the e2e Sessionize fixture a sixth room running 2x20 minute talks against the other rooms' 45, and regenerates this repo's 9 agenda visual baselines.
Why
The fixture timetable was a uniform rectangle — five rooms moving in lockstep through five identical slots. That made a session's time slot and its time span interchangeable, so anything relying on that equivalence looked correct against the fixture while being wrong on a real conference day: a 45 minute talk genuinely does run against two separate 20 minute talks in another room.
Groundwork for a "build my agenda" feature, where one-pick-per-slot has to mean interval overlap rather than slot identity. Every fork gets the better fixture on its next
/core-pull.What was and wasn't carried up
website/e2e/fixtures/sessionize/model.ts,website/app/lib/sessionize-fixtures.test.ts. Both were byte-identical to the fork's pre-change versions beforehand, so this is a clean copy rather than a merge.conference-stubin the pinned Playwright container.conference/changes existed, so no stub counterpart edits were needed.Notes
Changeoverentries areisPlenumSession: true, meaning venue-wide, and a changeover in one room while every other room is mid-talk is not that.nx generate-sessionize-fixtures— no such target exists; the views are projected in memory bysessionize-server.ts.Verification
nx test website— 431 passed, 6 skippednx lint website— 0 errorsnx build website— cleannx e2e website— 55 passedpnpm vr— 81 passed, only the 9 agenda baselines changedForks
After this lands, forks should
/core-pull. dddperth already has this content, so its pull should merge cleanly.