Repository navigation
fix: address five defects found reviewing the upstream feature stack - #208
Merged
JakeGinnivan merged 5 commits intoOct 19, 2026
Merged
Conversation
JakeGinnivan
deleted the
jakeginnivan/fix-full-feature-review-findings
branch
October 19, 2026 01:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix five issues found while reviewing dddwa/ddd-core#22–#26 as complete features. All five also exist on dddperth main.
The planner issue also reintroduces ddd-core#21 through the new shared save hook. Keep this correction when resolving that stack's merge into upstream main.
Evidence
pnpm nx run-many -t test typecheck lint -p websitepasses, including 827 unit tests and the dependent production build. New tests exercise the real router, actual hook requests, Jira parsing and real SQLite statements.Merge Danger
Door: two-way
No schema migrations or configuration changes. Intended for one combined upstream fix PR after the five existing ddd-core PRs land.
Blast Radius: planners
Also affects sponsor sync and attendee shortlist counts. Shortlist serialization is per page; counts remain best effort. Volunteer checks retain the existing limitations around simultaneous edits by separate admins and moving shifts between differently aligned session grids.