Skip to content

fix: address five defects found reviewing the upstream feature stack - #208

Merged
JakeGinnivan merged 5 commits into
mainfrom
jakeginnivan/fix-full-feature-review-findings
Oct 19, 2026
Merged

JakeGinnivan merged 5 commits into
mainfrom
jakeginnivan/fix-full-feature-review-findings

Conversation

@JakeGinnivan

Copy link
Copy Markdown
Contributor

Summary

Fix five issues found while reviewing dddwa/ddd-core#22–#26 as complete features. All five also exist on dddperth main.

planner saves       refresh once after edits drain, rather than looping while idle
My Agenda           serialize shortlist requests to preserve browser identity and edit order
volunteer roster    check overlapping session intervals in the planner and store
Jira rich text      preserve attendee lines and join formatted inline text directly
Jira reconciliation compare pre-fetch profile snapshots before applying remote values

The planner issue also reintroduces ddd-core#21 through the new shared save hook. Keep this correction when resolving that stack's merge into upstream main.

Evidence

  • Before: regressions reproduced idle planner reloads (5 loader calls without editing), three concurrent initial shortlist requests, accepted overlapping volunteer assignments, flattened attendee names, and a successful sponsor save overwritten by a stale Jira snapshot.
  • After: pnpm nx run-many -t test typecheck lint -p website passes, including 827 unit tests and the dependent production build. New tests exercise the real router, actual hook requests, Jira parsing and real SQLite statements.
  • Browser checks: 27 My Agenda and feedback tests pass across the configured dark/light projects, after initializing the new worktree with the existing local D1 migrations. Visual regression was not run; these changes do not alter visual layout.
  • Existing collaboration tests still confirm committee edits and clears import immediately. Snapshot comparisons also protect saves within the same second and apply atomically with the profile updates.

Merge Danger

Door: two-way

No schema migrations or configuration changes. Intended for one combined upstream fix PR after the five existing ddd-core PRs land.

Blast Radius: planners

Also affects sponsor sync and attendee shortlist counts. Shortlist serialization is per page; counts remain best effort. Volunteer checks retain the existing limitations around simultaneous edits by separate admins and moving shifts between differently aligned session grids.

@JakeGinnivan
JakeGinnivan merged commit 5ff4b12 into main Oct 19, 2026
3 checks passed
@JakeGinnivan
JakeGinnivan deleted the jakeginnivan/fix-full-feature-review-findings branch October 19, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant