Repository navigation
fix: show curl errors when downloading ionCube loaders - #75
Merged
Merged
Conversation
## Short Summary (TL;DR) Make the loader download fail with the HTTP error instead of saving the error page and failing later in `tar`. ## The Issue - Related to ddev/ddev-nvm#6 `curl -L` without `--fail` saves a 4xx/5xx response as `ioncube_loaders.tar.gz`, and the build then fails with `gzip: stdin: not in gzip format`, which doesn't say what went wrong. ## How This PR Solves The Issue Use `curl -fsSL --retry 3`, so curl retries transient errors and prints the HTTP status if the download fails. ## Manual Testing Instructions ```bash ddev add-on get ddev/ddev-ioncube --pr 75 ddev restart --no-cache ddev php -v ``` ## Automated Testing Overview No new tests, the existing tests cover the download. ## Release/Deployment Notes None. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Summary (TL;DR)
Make the loader download fail with the HTTP error instead of saving the error page and failing later in
tar.The Issue
ddev restartddev-nvm#6curl -Lwithout--failsaves a 4xx/5xx response asioncube_loaders.tar.gz, and the build then fails withgzip: stdin: not in gzip format, which doesn't say what went wrong.How This PR Solves The Issue
Use
curl -fsSL --retry 3, so curl retries transient errors and prints the HTTP status if the download fails.Manual Testing Instructions
Automated Testing Overview
No new tests, the existing tests cover the download.
Release/Deployment Notes
None.