Skip to content

Cover all override directives in the apple_support CI guard #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzcgumn merged 29 commits into from
Oct 16, 2026
Merged

Cover all override directives in the apple_support CI guard #424

Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
d6aecb1
Cover all five override directives in the apple_support guard.
zzcgumn Oct 10, 2026
2c95756
Parse bazel_dep's apple_support version independently of argument order.
zzcgumn Oct 10, 2026
d9589ac
Use a balanced-paren/string/comment-aware scanner for call bodies.
zzcgumn Oct 10, 2026
a8ffd41
Address PR #424 review: add missing git_override test, fix stale docs…
zzcgumn Oct 10, 2026
8c8e2b0
Ignore commented-out MODULE.bazel calls in the call-body scanner.
zzcgumn Oct 10, 2026
a718733
Tolerate whitespace before "(" and mask comments out of call bodies.
zzcgumn Oct 10, 2026
d1e88a8
Parse real keyword=value tokens instead of regex-searching masked bod…
zzcgumn Oct 10, 2026
24db5d1
Handle triple-quoted strings and identifier boundaries correctly.
zzcgumn Oct 10, 2026
68367e3
Capture positional module_name/name arguments, not just keyword form.
zzcgumn Oct 10, 2026
fa49355
Extract triple-quoted string values instead of discarding them.
zzcgumn Oct 10, 2026
f59da4d
Decode Starlark backslash escapes instead of stripping the backslash.
zzcgumn Oct 10, 2026
539a86c
Decode Starlark \u/\U Unicode escapes in module_name values.
zzcgumn Oct 10, 2026
975ebee
Fail closed on a non-literal module_name in override detection.
zzcgumn Oct 11, 2026
3a20362
Fail closed for any incomplete literal, not just one followed by "+".
zzcgumn Oct 11, 2026
2423efe
Fail closed on a parenthesized positional module_name expression.
zzcgumn Oct 11, 2026
614a2f4
Fail closed on list/dict positional module_name expressions.
zzcgumn Oct 12, 2026
7d162ae
Skip comments, not just whitespace, between "=" and a keyword's RHS.
zzcgumn Oct 12, 2026
43f561d
Recognize a parenthesized-callable-indirection call form.
zzcgumn Oct 12, 2026
0e22b4f
Decode backslash-newline line continuations instead of keeping both.
zzcgumn Oct 12, 2026
4468a31
Recognize raw string literals instead of misreading them as unresolved.
zzcgumn Oct 12, 2026
0a416ab
Skip comments, not just whitespace, in grouped-call detection.
zzcgumn Oct 12, 2026
91b57ff
Handle triple-quote delimiters in raw string literals.
zzcgumn Oct 13, 2026
f43d0ce
Recursively unwrap nested grouped-callable parens.
zzcgumn Oct 15, 2026
a1b4328
Handle backslash parity in raw strings; capture bazel_dep's 2nd posit…
zzcgumn Oct 15, 2026
5fcf08b
Use the raw-aware string dispatcher in the outer scan; skip comments …
zzcgumn Oct 15, 2026
2b1efe9
Handle line continuations, comments before "(", and nested override c…
zzcgumn Oct 16, 2026
5725299
Exclude spaced attribute calls; classify each call argument only once.
zzcgumn Oct 16, 2026
d935001
Parse MODULE.bazel with Python's ast instead of a hand-written lexer.
zzcgumn Oct 16, 2026
22b30ab
Fail closed when **kwargs could supply an override's module_name.
zzcgumn Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading