Repository navigation
Conversation
Silence rules_python 2.4+ warnings from our targets and from dependencies that still rely on auto-created inits; remove the flag once those deps catch up. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The workspace-wide Python import behavior change still needs the planned build and compatibility smoke tests.
No open issues 🎉
What changed in this PR
Disables legacy implicit __init__.py generation by default across the Bazel workspace to suppress rules_python deprecation warnings.
Changes:
- Enables
--incompatible_default_to_explicit_init_py. - Documents dependency coverage and when to remove the flag.
| File | Description |
|---|---|
.bazelrc |
Sets the explicit-init default and explains its purpose. |
Review effort: Balanced
tameware
added
the
Clean Copilot review
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build --incompatible_default_to_explicit_init_pyin.bazelrcso rules_python 2.4+ stops warning about deprecated auto-created__init__.pyfilesTest plan
bazelisk build //web:dds_web_html_test //python:solve_board_test— no implicit-__init__.pyWARNING linesbazelisk test //python/...smoke (or a representative subset) still passesMade with Cursor